Re: svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/curl/interface.c branches/PHP_5_3/ext/curl/tests/bug48203.phpt
branches/PHP_5_3/ext/curl/tests/bug54798.phpt branches/PHP_5_4/ext/curl/interface.c branches/PHP_5_4/ext/curl/t
On Thu, Sep 8, 2011 at 21:53, Alexey Shein <[email protected]> wrote:
> Hello, Hannes!
> It seems your fix is wrong, bug54798 still fails on my machine on
> trunk, 5.4 and 5.3 branches (ubuntu x64).
> IMO you should move your patch one line upper, i.e. before call to
> _php_curl_cleanup_handle(ch); since error is rasing there.
Hmmh. Your right, it is failing. Maybe I screwed something up while
merging between the branches.
I'll check it out.
> There's also related bug with curl_multi part, see bug48203_multi.phpt
> These tests fail for me now on trunk (it seems I forgot to add some of
> them to other branches, please, consider trunk first):
It was quite confusing why some tests were passing in 5_4, but the
same test didn't on trunk. Turns out the trunk test wasn't even
remotely similar to the 5_4 test yesterday :)
I've merged the test cases now so it should be easier to figure out
what is going on :]
There are several memleaks also detected by the test suite that needs
to be looked at.
-Hannes
Thread (2 messages)