Expose common factorisations #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwscook
changed the title
andreasnoack
reviewed
Feb 9, 2024
Member
andreasnoack
left a comment
andreasnoack
left a comment
There was a problem hiding this comment.
This mostly looks good. Some minor comments.
Contributor
Author
|
Is there anything else anyone would like done before this can be merged? |
andreasnoack
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to be able to use the in-place versions of
Cholesky,LU,QRandLQfactorisations available in the C++ library. This is a work-in-progress PR to enable this functionality. As of now, the following are tested and pass:QRLQLUCholeskyAlso: