Restore Dates.default_format(::Type{ZonedDateTime})
#497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was removed in #483 as we believed this was only used with parsing. We did discover that there were some legitimate use cases of this with
Dates.format: quinnj/JSON3.jl#313. I thought maybe we could modify JSON3.jl to work around this but while implementing that change I changed my mind on what was the right approach.As of now I think that:
Dates.default_formatfor parsing as they won't be able to parseZonedDateTimestrings without milliseconds. They should useparse(ZonedDateTime, str)instead.Date.formatit is reasonable to useDates.default_format(::Type{ZonedDateTime}).