Skip to content

rec: Generate EDE in more cases, specifically on unreachable auths or sythesized results. #12334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omoerbeek merged 5 commits into from
Jan 3, 2023
Merged

rec: Generate EDE in more cases, specifically on unreachable auths or sythesized results. #12334

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3e5667f
Generate EDE in more cases, specifically on unreachable auths or synt…
omoerbeek Dec 14, 2022
5eb762a
Reformat
omoerbeek Dec 16, 2022
718c531
Introduce a context object holding vState and extendedErrors
omoerbeek Dec 16, 2022
811bddf
A few tests on the new EDEs
omoerbeek Dec 20, 2022
79cc1d6
Make a distinction between "ordinary" negcache results and entire nam…
omoerbeek Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make a distinction between "ordinary" negcache results and entire nam… 
…e results.
  • Loading branch information
@omoerbeek
omoerbeek committed Jan 3, 2023
commit 79cc1d60fcb0b8de2375557ed963d266625e87f5
10 changes: 6 additions & 4 deletions pdns/recursordist/syncres.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2822,13 +2822,15 @@ bool SyncRes::doCacheCheck(const DNSName& qname, const DNSName& authname, bool w
if (ne.d_qtype.getCode()) {
LOG(prefix << qname << ": " << qtype << " is negatively cached via '" << ne.d_auth << "' for another " << sttl << " seconds" << endl);
res = RCode::NoError;
if (s_addExtendedResolutionDNSErrors) {
context.extendedError = EDNSExtendedError{0, "Result from negative cache"};
}
}
else {
LOG(prefix << qname << ": Entire name '" << qname << "' is negatively cached via '" << ne.d_auth << "' for another " << sttl << " seconds" << endl);
}
if (s_addExtendedResolutionDNSErrors) {
// XXX Do we want this?
context.extendedError = EDNSExtendedError{0, "Result from negative cache"};
if (s_addExtendedResolutionDNSErrors) {
context.extendedError = EDNSExtendedError{0, "Result from negative cache for entire name"};
}
}
}
}
Expand Down