-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(spec)!: Add a required protocol version to the agent card. #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @dmandar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new protocolVersion field to the AgentCard specification. This change allows agents to explicitly declare the version of the A2A protocol they support, which is crucial for ensuring compatibility and managing future protocol evolution.
Highlights
- Specification Update: The A2A specification documentation (
docs/specification.md) has been updated to formally define the newprotocolVersionfield as a required string in theAgentCardand includes an example of its usage. - gRPC Protocol Definition: The
AgentCardmessage in the gRPC protobuf definition (specification/grpc/a2a.proto) now includes theprotocol_versionfield, ensuring consistency across protocol implementations. - TypeScript Type Definition: The
AgentCardTypeScript interface (types/src/types.ts) has been updated to include theprotocolVersionproperty, complete with JSDoc documentation and an example, providing type safety for clients.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a protocolVersion field to the AgentCard across the specification, Protobuf definitions, and TypeScript types. The changes are consistent and correctly implement the feature. I have one suggestion regarding the field ordering in the Protobuf definition to align with the Google Protobuf Style Guide for better maintainability.
🤖 I have created a release *beep* *boop* --- ## [0.2.5](v0.2.4...v0.2.5) (2025-06-30) ### ⚠ BREAKING CHANGES * **spec:** Add a required protocol version to the agent card. ([#802](#802)) * Support for multiple pushNotification config per task ([#738](#738)) ([f355d3e](f355d3e)) ### Features * **spec:** Add a required protocol version to the agent card. ([#802](#802)) ([90fa642](90fa642)) * **spec:** Support for multiple pushNotification config per task ([#738](#738)) ([f355d3e](f355d3e)) ### Documentation * update spec & doc topic with non-restartable tasks ([#770](#770)) ([ebc4157](ebc4157)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Holt Skinner <[email protected]>
Add a new protocol version field to the agent card.
Release-As: 0.2.5