feat!: Add method for fetching extended card #929

kthota-g · 2025-07-28T18:43:34Z

Description

This change adds support for a new JSON-RPC method agent/getAuthenticatedExtendedCard for fetching authenticated extended card.

This is only applicable if AgentCard.supportsAuthenticatedExtendedCard bit is set to true that allows fetching authenticated context specific agent card.

In the previous versions, the extended card was served via {AgentCard.url}/../agent/authenticatedExtendedCard endpoint. This endpoint is being removed in favor of the JSON-RPC method. This endpoint will be deprecated in the SDKs and will be removed in a future release.

Release-As: 0.3.0

gemini-code-assist

Summary of Changes

Hello @kthota-g, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on extending the A2A specification by adding a new JSON-RPC method to fetch an 'extended card'. It includes the necessary type definitions for the request, successful response, and a dedicated error type for when the extended card is not configured. This change enhances the API's functionality by providing a structured way to retrieve this specific card information.

Highlights

New API Method Definition: This pull request introduces a new JSON-RPC method, agent/authenticatedExtendedCard, designed for fetching an extended card. This expands the A2A specification's capabilities.
Request and Response Types: New TypeScript interfaces and types have been defined for the agent/authenticatedExtendedCard method, including GetAuthenticatedExtendedCardRequest, GetAuthenticatedExtendedCardSuccessResponse, and GetAuthenticatedExtendedCardResponse, to standardize the communication structure.
New Error Type: A specific error type, AuthenticatedExtendedCardNotConfiguredError (with error code -32007), has been added to handle scenarios where an authenticated extended card is not configured, improving error handling clarity.
API Type Integration: The core JSONRPCResponse, A2ARequest, and A2AError union types have been updated to incorporate the newly defined request, response, and error types, ensuring they are recognized within the A2A specification.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces the agent/authenticatedExtendedCard method for fetching an extended agent card and adds corresponding TypeScript types. The review includes suggestions for improving type safety, documentation, and ensuring proper handling of the new method, response, and error types throughout the application.

types/src/types.ts

kthota-g · 2025-07-28T19:43:23Z

/gemini review

gemini-code-assist

Code Review

This pull request successfully refactors the method for fetching an extended agent card from a REST-style GET endpoint to a proper JSON-RPC method. The changes are consistent across the specification document, JSON schema, and TypeScript types. I've left a few comments to improve the consistency of the documentation, particularly around error handling, and to correct some copy-paste errors in descriptions within the schema and type files. Overall, this is a good improvement that aligns the new method with the rest of the A2A protocol.

specification/json/a2a.json

types/src/types.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

docs/specification.md

types/src/types.ts

# Description Types are manually generated for implementing this PR, but this feature has types dependency on a2aproject/A2A#929 and can only be merged once the type changes are merged into this repository. This PR adds support for agent/authenticatedExtendedCard JSON-RPC method for serving authenticated extended card. The previous HTTP GET /agent/authenticatedExtendedCard endpoint has been deprecated and will be removed in a future release. Release-As: 0.3.0

🤖 I have created a release *beep* *boop* --- ## [0.3.0](v0.2.6...v0.3.0) (2025-07-30) ### ⚠ BREAKING CHANGES * Add mTLS to SecuritySchemes, add oauth2 metadata url field, allow Skills to specify Security ([#901](#901)) * Change Well-Known URI for Agent Card hosting from `agent.json` to `agent-card.json` ([#841](#841)) * Add method for fetching extended card ([#929](#929)) ### Features * Add `signatures` to the `AgentCard` ([#917](#917)) ([ef4a305](ef4a305)) * Add method for fetching extended card ([#929](#929)) ([2cd7d98](2cd7d98)) * Add mTLS to SecuritySchemes, add oauth2 metadata url field, allow Skills to specify Security ([#901](#901)) ([e162c0c](e162c0c)) ### Bug Fixes * **spec:** Add `SendMessageRequest.request` `json_name` mapping to `message` ([#904](#904)) ([2eef3f6](2eef3f6)) * **spec:** Add Transport enum to specification ([#909](#909)) ([e834347](e834347)) ### Code Refactoring * Change Well-Known URI for Agent Card hosting from `agent.json` to `agent-card.json` ([#841](#841)) ([0858ddb](0858ddb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

kthota-g and others added 2 commits July 28, 2025 11:42

feat: Add method for fetching extended card

5975865

chore: Auto-generate a2a.json from types.ts changes

7e22e65

gemini-code-assist bot reviewed Jul 28, 2025

View reviewed changes

types/src/types.ts Show resolved Hide resolved

types/src/types.ts Outdated Show resolved Hide resolved

types/src/types.ts Outdated Show resolved Hide resolved

kthota-g and others added 3 commits July 28, 2025 11:49

Update spec

feb5999

Address comments

f7c3dd1

chore: Auto-generate a2a.json from types.ts changes

c77cbd3

Merge branch 'main' into kthota/extended-card-method

0c55cc3

gemini-code-assist bot reviewed Jul 28, 2025

View reviewed changes

specification/json/a2a.json Outdated Show resolved Hide resolved

types/src/types.ts Outdated Show resolved Hide resolved

kthota-g and others added 2 commits July 28, 2025 12:45

Update types/src/types.ts

1756a3f

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

chore: Auto-generate a2a.json from types.ts changes

0787a66

kthota-g changed the title ~~feat: Add method for fetching extended card~~ feat!: Add method for fetching extended card Jul 28, 2025

kthota-g added this to the 0.3.0 Release milestone Jul 28, 2025

kthota-g marked this pull request as ready for review July 28, 2025 21:28

kthota-g requested review from a team as code owners July 28, 2025 21:28

kthota-g added 2 commits July 28, 2025 15:07

Fix linting error

fa5b175

Linting

cf724bb

kthota-g mentioned this pull request Jul 29, 2025

feat!: Add support for authenticated extended card method a2aproject/a2a-python#356

Merged

dmandar approved these changes Jul 29, 2025

View reviewed changes

docs/specification.md Outdated Show resolved Hide resolved

kthota-g and others added 2 commits July 29, 2025 09:00

use verb for action

b207fbf

chore: Auto-generate a2a.json from types.ts changes

cbe5d6a

holtskinner reviewed Jul 29, 2025

View reviewed changes

types/src/types.ts Outdated Show resolved Hide resolved

Update types/src/types.ts

b4ce1a5

holtskinner approved these changes Jul 29, 2025

View reviewed changes

kthota-g and others added 3 commits July 29, 2025 09:04

Update spec and fix linting errors

63a9d11

chore: Auto-generate a2a.json from types.ts changes

a5fa3e7

Merge branch 'main' into kthota/extended-card-method

bec47d2

kthota-g merged commit 2cd7d98 into main Jul 29, 2025
5 checks passed

kthota-g deleted the kthota/extended-card-method branch July 29, 2025 16:31

release-please bot mentioned this pull request Jul 29, 2025

chore(main): release 0.3.0 #906

Merged

therealtimex mentioned this pull request Jul 30, 2025

Suport A2A v0.3.0 with breaking changes mozilla-ai/any-agent#691

Closed

noklam mentioned this pull request Oct 1, 2025

Support protocolVersion 0.3.0 pydantic/fasta2a#31

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat!: Add method for fetching extended card #929

feat!: Add method for fetching extended card #929

Uh oh!

kthota-g commented Jul 28, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kthota-g commented Jul 28, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat!: Add method for fetching extended card #929

feat!: Add method for fetching extended card #929

Uh oh!

Conversation

kthota-g commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kthota-g commented Jul 28, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kthota-g commented Jul 28, 2025 •

edited

Loading