Skip to content

Conversation

@kthota-g
Copy link
Collaborator

@kthota-g kthota-g commented Jul 16, 2025

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Release-As: 0.2.6

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @kthota-g, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the A2A protocol's type definitions and enhancing its documentation. It addresses a specific type fix by making a configuration field optional and provides clearer guidance on the appropriate use of Task, Message, and Artifact objects within the protocol specification.

Highlights

  • Type Definition Update: The acceptedOutputModes property within the MessageSendConfiguration interface in types/src/types.ts has been updated to be optional (acceptedOutputModes?: string[]). This change likely addresses a scenario where this field might not always be present.
  • Documentation Clarification (Artifacts): Documentation in docs/specification.md and docs/topics/key-concepts.md has been updated to explicitly state that tasks in a completed state should use artifacts for returning generated output to clients. This clarifies the intended use of Artifact objects for task results.
  • Documentation Clarification (Messages vs. Artifacts): The docs/topics/key-concepts.md file now more clearly distinguishes Messages from Artifacts, noting that messages convey information not necessarily formal Artifacts part of a Task.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a type fix by making acceptedOutputModes optional in MessageSendConfiguration and clarifies documentation regarding the use of Artifacts in completed Tasks.

kthota-g and others added 2 commits July 16, 2025 14:41
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@kthota-g kthota-g marked this pull request as ready for review July 16, 2025 21:43
@kthota-g kthota-g requested a review from a team as a code owner July 16, 2025 21:43
@holtskinner holtskinner merged commit 6f1d17b into main Jul 17, 2025
5 checks passed
@holtskinner holtskinner deleted the kthota/type-fixes branch July 17, 2025 16:10
holtskinner added a commit that referenced this pull request Jul 17, 2025
🤖 I have created a release *beep* *boop*
---


## [0.2.6](v0.2.5...v0.2.6)
(2025-07-17)

### Bug Fixes

* Type fix and doc clarification
([#877](#877))
([6f1d17b](6f1d17b))
* Update json names of gRPC objects for proper transcoding
([#847](#847))
([6ba72f0](6ba72f0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Holt Skinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants