Skip to content

Conversation

@coreymasanto
Copy link
Contributor

Substitute the undefined this.state_ for this.state so that the page attachment's scroll position resets whenever the attachment closes, as intended.

@amp-owners-bot amp-owners-bot bot requested a review from raxsha August 23, 2021 21:49
@amp-owners-bot
Copy link

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-draggable-drawer.js

@mszylkowski mszylkowski requested review from mszylkowski and removed request for raxsha August 23, 2021 21:54
Copy link
Contributor

@gmajoulet gmajoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmajoulet gmajoulet merged commit 784577a into ampproject:main Aug 24, 2021
@processprocess
Copy link
Contributor

Thank you for catching this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants