🖍 [Story performance] Set css units on desktop for supports-landscape and regular one-panel #36033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszylkowski
changed the title
|
Hey @gmajoulet, @newmuis! These files were changed: |
gmajoulet
reviewed
Sep 17, 2021
Contributor
gmajoulet
left a comment
gmajoulet
left a comment
There was a problem hiding this comment.
With this implementation you calculate story-page-vh/w in 3 different places. Let's do CSS only, and factorize further so the code can grow in a healthy way.
gmajoulet
approved these changes
Sep 24, 2021
processprocess
approved these changes
Oct 6, 2021
samouri
pushed a commit
to samouri/amphtml
that referenced
this pull request
Oct 7, 2021
… and regular one-panel (ampproject#36033) * Added CSS rules for units * Removed 50vw * Added font and example files * Add support for desktop panels * Fix supports-landscape * Fixed units CSS, removed JS * Removed unused dep * Remove unused JS style element * Fix vertical rendering * Fixed list.push to list.add * Fixed one-panel rems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #36007
Closes #36045 #36046
Brings CSS support for the sizing variables on desktop one panel and desktop landscape.
In order to style the
font-sizedepending on whether the story issupports-landscapeor not, the transformers will need to add adata-story-supports-landscapeon the root of the document (htmltag) so that therems are set properly. There's no way to know whatrems to use (the value for 1-panel or landscape) from the root, since there are no selectors with the logic to select based on the children.The story will work as expected when the story doesn't support landscape, or when the publisher adds the
data-story-supports-landscape(which is added forsupports-landscapestories on the runtime to not rely on the creator and ensure built state is good).