🚀 [Story share] Move share menu to separate bundle #37179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszylkowski
changed the title
|
Hey @gmajoulet, @newmuis! These files were changed: |
gmajoulet
reviewed
Dec 13, 2021
Contributor
gmajoulet
left a comment
gmajoulet
left a comment
There was a problem hiding this comment.
Consider this one approved, but I'll wait for formal approval so we submit all PRs at once :))
gmajoulet
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #37198
Closes #37203
Moving the share menu of amp-story to a new extension.
This PR will directly import the share menu on
amp-story.jsand not lazy load it, since we'd need to move more functionality betweenamp-story-shareandamp-story-share-menubefore that's possible (and the PR would get too large). Check the I2I for the steps.This PR will improve the loading performance by not importing
amp-social-shareif the sharing is native, only if it's fallback. The native system sharing will be taken care of by theamp-storycompletely in a followup PR, but it's removed from the share menu in this PR to prevent moving unnecessary code.Tested on Android (for system share) and Mac (for fallback share)