🚮 🐛 [amp story 360] Remove GL context handling #38144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gmajoulet, @t0mg! These files were changed: |
gmajoulet
approved these changes
Apr 27, 2022
Contributor
gmajoulet
left a comment
gmajoulet
left a comment
There was a problem hiding this comment.
Can we keep the code behind an experiment flag, so it's easier to bring it back if we decide to spend more time debugging the race condition?
We could also just revert this revert, so still LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the context handling code from the 360 component.
Removing this code is not a final solution but will allow 360 to work in most use cases until the root of the bug is resolved.
Additional context:
GL context handling was implemented to lose and restore web gl context based on distance from the active page. Browsers limit contexts to 8-16. Web Stories that feature 360 such as this one use less than the maximum.
This context handling broke within the past several months. Context is not restored and a blank screen is displayed. In some cases context is created but then lost right after.
The codepen example still works which leads me to believe it's a race condition within the amp story codebase. I'm unable to identify the cause of this bug at this time.
cc @t0mg