Skip to content

protocol adapters: e2e test, nodom binary, and bump worker-dom. #29541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samouri merged 4 commits into from
Aug 3, 2020
Merged

protocol adapters: e2e test, nodom binary, and bump worker-dom. #29541

samouri merged 4 commits into from
Aug 3, 2020

Conversation

@samouri
Copy link
Member

@samouri samouri commented Jul 28, 2020 •
edited
Loading

summary

  • Bumps worker-dom to 0.25.2 which has nodom build support.
  • Introduce nodom attribute for <amp-script>, yielding a tiny worker bundle size and 0 size requirement.
  • Creates basic e2e test for the happy path

next step

  • Documentation!

@samouri samouri self-assigned this Jul 28, 2020
@google-cla google-cla bot added the cla: no label Jul 28, 2020
@google-cla google-cla bot added cla: yes and removed cla: no labels Jul 28, 2020
@samouri samouri changed the title protocol adapters: e2e test, lite binary, and bump worker-dom. protocol adapters: e2e test, nodom binary, and bump worker-dom. Jul 28, 2020
@ampproject ampproject deleted a comment from google-cla bot Jul 28, 2020
@samouri samouri mentioned this pull request Jul 28, 2020
Closed
@samouri samouri marked this pull request as ready for review July 28, 2020 20:35
samouri
samouri commented Jul 29, 2020
View reviewed changes
samouri
samouri commented Jul 29, 2020
View reviewed changes
@samouri
Copy link
Member Author

samouri commented Jul 30, 2020

@jridgewell: can I get your review for extensions-helper.js? Thanks!

@samouri samouri mentioned this pull request Jul 30, 2020
Merged
samouri added 4 commits August 3, 2020 10:30
@samouri
amp-script: nodom variant
fe0441f 
- adds support for nodom flag to amp-script, for protocol adapters.
- upgrades worker-dom to the latest (which has support for callFunction,
and lite binaries).
- adds e2e test for "script" uri in amp-list.
@samouri
lint
8a5fa7d
@samouri
force nodom to not have width/height.
7940bc7
@samouri
2019 --> 2020
9cb769e
@samouri samouri merged commit d729dee into ampproject:master Aug 3, 2020
@samouri samouri deleted the nodom branch August 3, 2020 15:50
@dreamofabear dreamofabear mentioned this pull request Aug 3, 2020
Closed
@diegofernandezmrf diegofernandezmrf mentioned this pull request Aug 5, 2020
Closed
1 task
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
@samouri @ed-bird
protocol adapters: e2e test, nodom binary, and bump worker-dom. (ampp…
f39aa77 
…roject#29541)

* amp-script: nodom variant

- adds support for nodom flag to amp-script, for protocol adapters.
- upgrades worker-dom to the latest (which has support for callFunction,
and lite binaries).
- adds e2e test for "script" uri in amp-list.

* lint

* force nodom to not have width/height.

* 2019 --> 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jridgewell jridgewell jridgewell approved these changes

@dreamofabear dreamofabear dreamofabear approved these changes

Assignees

@samouri samouri

Labels

cla: yes Component: amp-list Component: amp-script PR use: In Beta / Experimental WG: runtime

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samouri @jridgewell @dreamofabear @ampprojectbot