♻️ [Amp story shopping] Attachment as element child #36989
Next
Next commit
Append drawer child
- Loading branch information
commit 6c092af06439d4fc220d0d0e34d983587ac42e3f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,43 @@ | ||
| import * as Preact from '#core/dom/jsx'; | ||
| import {Layout_Enum} from '#core/dom/layout'; | ||
| import {once} from '#core/types/function'; | ||
|
|
||
| export class AmpStoryShoppingAttachment extends AMP.BaseElement { | ||
processprocess marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| /** @param {!AmpElement} element */ | ||
| constructor(element) { | ||
| super(element); | ||
|
|
||
| /** @private @return {extensions/amp-story/1.0/amp-story-page-attachment.js.AmpStoryPageAttachment} */ | ||
| this.attachmentEl_ = null; | ||
|
|
||
| /** | ||
| * Caches a reference to the attachmnet's impl. | ||
| * @private @return {extensions/amp-story/1.0/amp-story-page-attachment.js.AmpStoryPageAttachment} | ||
| * */ | ||
| this.getAttachmentImpl_ = once(() => | ||
| customElements | ||
| .whenDefined('amp-story-page-attachment') | ||
| .then(() => this.attachmentEl_.getImpl()) | ||
| ); | ||
| } | ||
|
|
||
| /** @override */ | ||
| buildCallback() { | ||
| this.attachmentEl_ = ( | ||
| <amp-story-page-attachment layout="nodisplay"></amp-story-page-attachment> | ||
| ); | ||
| this.element.appendChild(this.attachmentEl_); | ||
| } | ||
|
|
||
| /** | ||
| * @param {boolean=} shouldAnimate | ||
processprocess marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| */ | ||
| open(shouldAnimate = true) { | ||
processprocess marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| this.getAttachmentImpl_().then((impl) => impl.open(shouldAnimate)); | ||
| } | ||
|
|
||
| /** @override */ | ||
| isLayoutSupported(layout) { | ||
| return layout == Layout_Enum.FILL; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.