Skip to content

🚀 [Story performance] Remove share menu from main amp-story bundle #37235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mszylkowski merged 29 commits into from
Dec 22, 2021
Merged

🚀 [Story performance] Remove share menu from main amp-story bundle #37235

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
90a4237
Move building share menu to share-menu.js
mszylkowski Dec 13, 2021
38e02db
Reorganized share-menu.js
mszylkowski Dec 14, 2021
a3c76cc
Working share menu with proper split
mszylkowski Dec 14, 2021
9485073
Fixed dep-check, streamlined build
mszylkowski Dec 14, 2021
4627523
Fixed styling
mszylkowski Dec 14, 2021
462bb94
Cleaned up
mszylkowski Dec 14, 2021
cd68d5f
Updated comment
mszylkowski Dec 14, 2021
9a77fb7
CanonicalURL is unnecessary in constructor
mszylkowski Dec 14, 2021
9feca68
Fixed tests
mszylkowski Dec 15, 2021
d677cbd
Removed outdated amp-story links
mszylkowski Dec 15, 2021
c97aad9
Fixed lint errors
mszylkowski Dec 15, 2021
5c303e2
Merge branch 'main' of github.com:ampproject/amphtml into removeShare…
mszylkowski Dec 15, 2021
439cee0
Merge branch 'main' of github.com:ampproject/amphtml into removeShare…
mszylkowski Dec 15, 2021
c5eedef
Merge branch 'main' of github.com:ampproject/amphtml into removeShare…
mszylkowski Dec 16, 2021
16b8153
Removed share menu from amp-story extension
mszylkowski Dec 16, 2021
54dd432
Merge branch 'main' of github.com:ampproject/amphtml into removeShare…
mszylkowski Dec 20, 2021
15c386c
Merge branch 'main' of github.com:ampproject/amphtml into removeShare…
mszylkowski Dec 20, 2021
8ba6918
Fixed dep check
mszylkowski Dec 20, 2021
6465db7
Removed useless test
mszylkowski Dec 20, 2021
ed8d5c6
Added owners
mszylkowski Dec 20, 2021
643c69c
Transformed to BaseElement
mszylkowski Dec 20, 2021
60c3d26
Fixed tests
mszylkowski Dec 20, 2021
0b62241
Fixed visual tets
mszylkowski Dec 20, 2021
28641cf
Resolve depcheck
mszylkowski Dec 20, 2021
264af79
Fixed visual tests
mszylkowski Dec 20, 2021
3edc872
Removed console log
mszylkowski Dec 20, 2021
f9fff82
Fixed visual tests
mszylkowski Dec 20, 2021
b41fd82
Fixed invalid whitespaces
mszylkowski Dec 20, 2021
5bfc62f
Merge branch 'main' of github.com:ampproject/amphtml into removeShare…
mszylkowski Dec 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' of github.com:ampproject/amphtml into removeShare… 
…_splitMenu
  • Loading branch information
@mszylkowski
mszylkowski committed Dec 20, 2021
commit 15c386c2dc1dd3354abd362c47f1c7bcfb09e939

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.