remove unnecessary update

TaiJuWu · TaiJuWu · commit 4c48bfc1c9a2 · 2025-10-17T12:54:55.000+08:00
diff --git a/raft/src/main/java/org/apache/kafka/raft/LeaderState.java b/raft/src/main/java/org/apache/kafka/raft/LeaderState.java
@@ -163,6 +163,7 @@ protected LeaderState(
             ReplicaState state = new ReplicaState(voterNode.voterKey(), hasAcknowledgedLeader, voterNode.listeners());
             this.voterStates.put(voterNode.voterKey().id(), state);
             if (isInitializing) {
+                log.debug("put " + state + " into CommittedVoterStates");
                 this.committedVoterStates.put(voterNode.voterKey().id(), state);
             }
         }
@@ -720,7 +721,6 @@ private boolean maybeUpdateHighWatermark() {
 
         int indexOfHw = voterStates.size() / 2;
         Optional<LogOffsetMetadata> highWatermarkUpdateOpt = followersByDescendingFetchOffset.get(indexOfHw).endOffset;
-        highWatermark.ifPresent(this::updateCommittedVoter);
 
         if (highWatermarkUpdateOpt.isPresent()) {
 

Original file line number	Diff line number	Diff line change
`@@ -163,6 +163,7 @@ protected LeaderState(`
`163`	`163`	`ReplicaState state = new ReplicaState(voterNode.voterKey(), hasAcknowledgedLeader, voterNode.listeners());`
`164`	`164`	`this.voterStates.put(voterNode.voterKey().id(), state);`
`165`	`165`	`if (isInitializing) {`
	`166`	`+ log.debug("put " + state + " into CommittedVoterStates");`
`166`	`167`	`this.committedVoterStates.put(voterNode.voterKey().id(), state);`
`167`	`168`	`}`
`168`	`169`	`}`
`@@ -720,7 +721,6 @@ private boolean maybeUpdateHighWatermark() {`
`720`	`721`
`721`	`722`	`int indexOfHw = voterStates.size() / 2;`
`722`	`723`	`Optional<LogOffsetMetadata> highWatermarkUpdateOpt = followersByDescendingFetchOffset.get(indexOfHw).endOffset;`
`723`		`- highWatermark.ifPresent(this::updateCommittedVoter);`
`724`	`724`
`725`	`725`	`if (highWatermarkUpdateOpt.isPresent()) {`
`726`	`726`