It looks like GenAPI misses this as well.

EG:

genapi --assembly .\System.ComponentModel.Annotations.dll --assembly-reference .\ --output-path da.cs

Produces

[Diagnostics.CodeAnalysis.RequiresUnreferencedCode("Generic TypeConverters may require the generic types to be annotated. For example, NullableConverter requires the underlying type to be DynamicallyAccessedMembers All.")]
public RangeAttribute(Type type, string minimum, string maximum) { }

Despite the actual syntax being

[RequiresUnreferencedCode("Generic TypeConverters may require the generic types to be annotated. For example, NullableConverter requires the underlying type to be DynamicallyAccessedMembers All.")]
public RangeAttribute([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.AllConstructors | DynamicallyAccessedMemberTypes.AllNestedTypes | DynamicallyAccessedMemberTypes.AllMethods | DynamicallyAccessedMemberTypes.AllFields | DynamicallyAccessedMemberTypes.AllProperties | DynamicallyAccessedMemberTypes.AllEvents | DynamicallyAccessedMemberTypes.Interfaces)] Type type, string minimum, string maximum)

It seems that SyntaxGenerator does not apply these, we apply them after getting the signature, but only to the member (not its parameters):

sdk/src/Compatibility/GenAPI/Microsoft.DotNet.GenAPI/CSharpAssemblyDocumentGenerator.cs

Lines 126 to 128 in 681138b

    
           SyntaxNode typeDeclaration = _syntaxGenerator 
        
               .DeclarationExt(typeMember, _options.SymbolFilter) 
        
               .AddMemberAttributes(_syntaxGenerator, typeMember, _options.AttributeSymbolFilter);

sdk/src/Compatibility/GenAPI/Microsoft.DotNet.GenAPI/SyntaxNodeExtensions.cs

Lines 16 to 38 in 681138b

    
           public static SyntaxNode AddMemberAttributes(this SyntaxNode node, 
        
               SyntaxGenerator syntaxGenerator, 
        
               ISymbol member, 
        
               ISymbolFilter attributeDataSymbolFilter) 
        
           { 
        
               foreach (AttributeData attribute in member.GetAttributes().ExcludeNonVisibleOutsideOfAssembly(attributeDataSymbolFilter)) 
        
               { 
        
                   // The C# compiler emits the DefaultMemberAttribute on any type containing an indexer. 
        
                   // In C# it is an error to manually attribute a type with the DefaultMemberAttribute if the type also declares an indexer. 
        
                   if (member is INamedTypeSymbol typeMember && typeMember.HasIndexer() && attribute.IsDefaultMemberAttribute()) 
        
                   { 
        
                       continue; 
        
                   } 
        
                   if (attribute.IsReserved()) 
        
                   { 
        
                       continue; 
        
                   } 
        
                   node = syntaxGenerator.AddAttributes(node, syntaxGenerator.Attribute(attribute)); 
        
               } 
        
               return node;

Adding attributes to parameters like this would require traversing symbols/syntax in parallel and add them back.

SyntaxGenerator is the thing that knows about the mapping between symbols and syntax, so it would be the ideal place to apply these. Unfortunately it doesn't have support for this today, and the places we'd need to extend to add support are private protected.

So the fix here would be to make AddMemberAttributes also traverse parameters in symbols, discover attributes, and apply those to the correct matching syntax nodes.

	SyntaxNode typeDeclaration = _syntaxGenerator
	.DeclarationExt(typeMember, _options.SymbolFilter)
	.AddMemberAttributes(_syntaxGenerator, typeMember, _options.AttributeSymbolFilter);

	public static SyntaxNode AddMemberAttributes(this SyntaxNode node,
	SyntaxGenerator syntaxGenerator,
	ISymbol member,
	ISymbolFilter attributeDataSymbolFilter)
	{
	foreach (AttributeData attribute in member.GetAttributes().ExcludeNonVisibleOutsideOfAssembly(attributeDataSymbolFilter))
	{
	// The C# compiler emits the DefaultMemberAttribute on any type containing an indexer.
	// In C# it is an error to manually attribute a type with the DefaultMemberAttribute if the type also declares an indexer.
	if (member is INamedTypeSymbol typeMember && typeMember.HasIndexer() && attribute.IsDefaultMemberAttribute())
	{
	continue;
	}

	if (attribute.IsReserved())
	{
	continue;
	}

	node = syntaxGenerator.AddAttributes(node, syntaxGenerator.Attribute(attribute));
	}

	return node;

APIDiff not catching change in parameters to attribute applied to a method parameter #49792

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions