This repository was archived by the owner on Jun 27, 2020. It is now read-only.
fix: fix incompatible receiver exception on chrome #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36, #37
Background: If you try to format some date with timezone which is not supported by the browser (e.g.
CETon Chrome) but is supported by the polyfill, code throwsIntl.DateTimeFormat.prototype.formatToParts called on incompatible receiver. This error happens rarely because modern browsers usually provide data for all timezones and they are only ones who care about correct call receiver (that's why it doesn't happen in IE11).Reason: Polyfill doesn't inherit native class correctly.
Solution: In Babel, it was fixed in this PR. I've tweaked the code a bit to support IE 10.
Environment to reproduce the issue (NB: It should be opened in Chrome): https://jsfiddle.net/t4q5xk0m/