fix(storage): persist resource in append retry#13128
Merged
tritone merged 3 commits intogoogleapis:release-storage-1.56.3from Oct 14, 2025
Merged
fix(storage): persist resource in append retry#13128tritone merged 3 commits intogoogleapis:release-storage-1.56.3from
tritone merged 3 commits intogoogleapis:release-storage-1.56.3from
Conversation
In one retry case for appendable writes, the client receives both an object resource w/ write handle as well as an error from the server. After reconnect the new stream would not keep the original object resource. This change ensures that the object is not dropped. I need to make a change to the emulator as well so that the testbench behavior more closely mocks the service.
product-auto-label
bot
added
the
api: storage
danielduhh
approved these changes
Oct 13, 2025
quartzmo
approved these changes
Oct 13, 2025
BrennaEpp
reviewed
Oct 14, 2025
BrennaEpp
approved these changes
Oct 14, 2025
tritone
merged commit 9ad2100
into
googleapis:release-storage-1.56.3
45 of 187 checks passed
tritone
added a commit
that referenced
this pull request
Oct 15, 2025
🤖 I have created a release *beep* *boop* --- ## [1.56.3](storage/v1.56.2...storage/v1.56.3) (2025-10-14) ### Bug Fixes * **storage:** Persist resource in append retry ([#13128](#13128)) ([9ad2100](9ad2100)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In one retry case for appendable writes, the client receives both an object resource w/ write handle as well as an error from the server. After reconnect the new stream would not keep the original object resource. This change ensures that the object is not dropped.
Also explicitly guarantee the contract that either w.Attrs() will be non-nil, or w.Close() will return a non-nil error.
I need to make a change to the emulator as well so that the testbench behavior more closely mocks the service.