fix: Add support for a metadata column named id (#421)

* fix: Add support for a metadata column named id

* Add test

* remove test to debug

* Add test

Author: dishaprakash

src/langchain_google_alloydb_pg/async_vectorstore.py

@@ -281,16 +281,16 @@ async def aadd_embeddings(
             )
             insert_stmt = f'INSERT INTO "{self.schema_name}"."{self.table_name}"("{self.id_column}", "{self.content_column}", "{self.embedding_column}"{metadata_col_names}'
             values = {
-                "id": id,
+                "langchain_id": id,
                 "content": content,
                 "embedding": str([float(dimension) for dimension in embedding]),
             }
-            values_stmt = "VALUES (:id, :content, :embedding"
+            values_stmt = "VALUES (:langchain_id, :content, :embedding"
             inline_embed_func = getattr(
                 self.embedding_service, "embed_query_inline", None
             )
             if not embedding and callable(inline_embed_func):
-                values_stmt = f"VALUES (:id, :content, {self.embedding_service.embed_query_inline(content)}"  # type: ignore
+                values_stmt = f"VALUES (:langchain_id, :content, {self.embedding_service.embed_query_inline(content)}"  # type: ignore
 
             # Add metadata
             extra = copy.deepcopy(metadata)

tests/test_async_vectorstore.py

@@ -40,6 +40,7 @@
 docs = [
     Document(page_content=texts[i], metadata=metadatas[i]) for i in range(len(texts))
 ]
+id_column_as_metadata = [{"id": str(i)} for i in range(len(texts))]
 
 embeddings = [embeddings_service.embed_query(texts[i]) for i in range(len(texts))]
 
@@ -209,6 +210,29 @@ async def test_post_init(self, engine):
                 metadata_json_column="mymeta",
             )
 
+    async def test_id_metadata_column(self, engine):
+        table_name = "id_metadata" + str(uuid.uuid4())
+        await engine._ainit_vectorstore_table(
+            table_name,
+            VECTOR_SIZE,
+            metadata_columns=[Column("id", "TEXT")],
+        )
+        custom_vs = await AsyncAlloyDBVectorStore.create(
+            engine,
+            embedding_service=embeddings_service,
+            table_name=table_name,
+            metadata_columns=["id"],
+        )
+        ids = [str(uuid.uuid4()) for i in range(len(texts))]
+        await custom_vs.aadd_texts(texts, id_column_as_metadata, ids)
+
+        results = await afetch(engine, f'SELECT * FROM "{table_name}"')
+        assert len(results) == 3
+        assert results[0]["id"] == "0"
+        assert results[1]["id"] == "1"
+        assert results[2]["id"] == "2"
+        await aexecute(engine, f'DROP TABLE IF EXISTS "{table_name}"')
+
     async def test_aadd_texts(self, engine, vs):
         ids = [str(uuid.uuid4()) for i in range(len(texts))]
         await vs.aadd_texts(texts, ids=ids)