fix: use original types for composite primary keys#246
Merged
olavloite merged 5 commits intogoogleapis:mainfrom May 15, 2023
Merged
fix: use original types for composite primary keys#246olavloite merged 5 commits intogoogleapis:mainfrom
olavloite merged 5 commits intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
the
api: spanner
nownabe
force-pushed
the
non-number-interleave-key
branch
from
8860f59 to
33dc0ab
Compare
nownabe
force-pushed
the
non-number-interleave-key
branch
from
33dc0ab to
880716c
Compare
Contributor
Author
|
I added a new test helper to allow us to create more flexible tests and to bundle related test code. |
olavloite
approved these changes
May 12, 2023
| end | ||
| end | ||
|
|
||
| def test_create_album |
Collaborator
There was a problem hiding this comment.
Would you mind adding a couple of tests for other basic operations as well:
- UpdateAlbum
- GetAlbum
And also verify that it is possible to get the albums of a singer (that is; iterate over the collection of albums of a singer)
| @@ -0,0 +1,41 @@ | |||
| require "securerandom" | |||
Collaborator
There was a problem hiding this comment.
nit: add a copyright header
You can copy one from any of the other files. Please make sure to update the year to 2023
To enable developers to run only this test case, specifying the test file, and to bundle test code related to the test.
Contributor
Author
|
@olavloite Thank you for your review! I updated them. |
olavloite
approved these changes
May 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #245