Skip to content

fix: support for changes in Rails 7.0.7#260

Merged
olavloite merged 1 commit intogoogleapis:mainfrom
ruzia:fix_for_rails707
Aug 28, 2023
Merged

fix: support for changes in Rails 7.0.7#260
olavloite merged 1 commit intogoogleapis:mainfrom
ruzia:fix_for_rails707

Conversation

@ruzia
Copy link
Contributor

@ruzia ruzia commented Aug 26, 2023

Using Rails 7.0.7, the following error occurs when performing database migration.
This pull-req is a fix for this.

$ bundle exec rails db:migrate
rails aborted!
NoMethodError: undefined method `quoted_table_names' for ActiveRecord::ConnectionAdapters::SpannerAdapter:Class

see also: https://github.com/rails/rails/pull/48773/files

@ruzia ruzia requested review from a team and olavloite as code owners August 26, 2023 08:01
@google-cla
Copy link

google-cla bot commented Aug 26, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/ruby-spanner-activerecord API. label Aug 26, 2023
@ruzia ruzia force-pushed the fix_for_rails707 branch from 44f3038 to 9b046c0 Compare August 26, 2023 08:06
@ruzia ruzia force-pushed the fix_for_rails707 branch from 9b046c0 to f1515db Compare August 27, 2023 01:45
@ruzia ruzia changed the title Support for changes in Rails 7.0.7. fix: Support for changes in Rails 7.0.7. Aug 28, 2023
@ruzia ruzia changed the title fix: Support for changes in Rails 7.0.7. fix: support for changes in Rails 7.0.7. Aug 28, 2023
@ruzia ruzia changed the title fix: support for changes in Rails 7.0.7. fix: support for changes in Rails 7.0.7 Aug 28, 2023
@ruzia
Copy link
Contributor Author

ruzia commented Aug 28, 2023

@olavloite Please let me know if there is anything needs to be changed​.

@olavloite
Copy link
Collaborator

LGTM. Thanks for updating this!

@ruzia
Copy link
Contributor Author

ruzia commented Sep 4, 2023

@olavloite Thanks for merge! πŸ™Œ
When do you plan to release this fix?

@olavloite
Copy link
Collaborator

We've been having some problems with integration tests that have been timing out. Once we have fixed that, we'll cut a new release that also includes this fix. The problem with the failing integration tests will be fixed in #258, so once that is merged, we'll do the release.

@ruzia
Copy link
Contributor Author

ruzia commented Sep 5, 2023

Thanks for response! πŸ˜„
I understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/ruby-spanner-activerecord API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants