fix: failed to convert active model type to spanner type under certain condition#299
Merged
olavloite merged 3 commits intogoogleapis:mainfrom Feb 19, 2024
Merged
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
…in condition Added support for the case where a DelegateClass such as ActiveRecord::AttributeMethods::TimeZoneConversion::TimeZoneConverter is passed to type.
5a33596 to
9b89518
Compare
Collaborator
|
@ruzia Would you mind adding a test for this, or otherwise add a code sample to this PR that shows how this would normally be used, then I can add a test case for it. |
Contributor
Author
|
I have created a simple rails application that causes problems. https://github.com/ruzia/type_conversion_test
I am connecting to Cloud Spanner on GCP, not an emulator. |
olavloite
approved these changes
Feb 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, such as time related columns, a
DelegateClasslikeActiveRecord::AttributeMethods::TimeZoneConversion::TimeZoneConverteris passed to the type.It cause
ArgumentError: Cannot determine type for nil values.exception at here.