Export minusNaturalMaybe from Numeric.Natural

[Zemyla]

The function minusNaturalMaybe already exists in GHC.Natural, is safe, and is faster and more total than comparing two Naturals and optionally subtracting them.

[mixphix]

This particular definition of minusNaturalMaybe uses primitives, so it would be marginally faster than the obvious workaround would be, handwritten. If you'd like to draw up a PR for us to vote on, I'd most likely be in favour.

[Bodigrim]

@hsyl20 what do you think about exposing minusNaturalMaybe from Numeric.Natural?

[Bodigrim]

I think it's a reasonable proposal. I'm a bit concerned that Numeric.Natural does not export anything except Natural itself at the moment, but I cannot think of a better module. And making safe subtraction of Natural more accessible and discoverable is a noble goal indeed.

Dear CLC members, let's vote on the proposal. @tomjaguarpaw @cgibbard @cigsender @emilypi @chessai

+1 from me.

[mixphix]

+1

[chessai]

+1

[tomjaguarpaw]

+1

[cgibbard]

+1

…

On Fri., May 20, 2022, 03:43 tomjaguarpaw, ***@***.***> wrote: +1 — Reply to this email directly, view it on GitHub <#45 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVVE3AJIRX7XNYGKRDBOO3VK47DJANCNFSM5PI4ZMSA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Bodigrim]

With 5 votes in favour out of 6 possible, the proposal is approved by CLC.

@Zemyla could you please create a GHC MR, which I can approve?

[Zemyla]

How do I do that?

[Bodigrim]

Fork https://gitlab.haskell.org/ghc/ghc, make a change in your fork and raise a merge request.

[Bodigrim]

@Zemyla just a reminder to open a merge request for this change.

[Zemyla]

I don't currently have a machine capable of doing that. Can someone else do it?

[ulysses4ever]

https://gitlab.haskell.org/ghc/ghc/-/merge_requests/8391/