Skip to content

Conversation

@jonashenrique90
Copy link

This PR improves the weekdaysMin for brazilian portuguese.

@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (27b3f61) to head (188c4eb).
⚠️ Report is 228 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #1846   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          180       180           
  Lines         2034      2034           
  Branches       524       524           
=========================================
  Hits          2034      2034           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iamkun
Copy link
Owner

iamkun commented Apr 14, 2022

I'll mark this PR to wait for some native speaker review.

also you can check https://github.com/moment/moment/blob/develop/src/locale/pt-br.js as a reference

@Garccez
Copy link

Garccez commented May 27, 2022

I'm a Brazilian Portuguese native speaker, the improved weekdaysMin this guy made is indeed more used than the one in use by DayJS ;)

@yanpgabriel
Copy link

I'm also a native speaker and I can confirm that using 2ª, 3ª, 4ª, 5ª, and 6ª is not at all conventional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants