Improve devHelper warning for missing CustomParseFormat plugin #2982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 26, 2025 11:20
Add a more precise check to only show the warning when a format string is actually passed as the second argument. This helps developers understand why their date parsing fails and guides them to enable the CustomParseFormat plugin.
Add a more precise check to only show the warning when a format string is actually passed as the second argument. This helps developers understand why their date parsing fails and guides them to enable the CustomParseFormat plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2954.
This PR addresses an inconsistency where parsing input like
dayjs('11/1/2004', 'MM/DD/YYYY')returned a valid date in Node.js but"Invalid Date"in some browsers. The goal is to make parsing behavior consistent across environments.