Skip to content

Improve devHelper warning for missing CustomParseFormat plugin #2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Albez0-An7h wants to merge 3 commits into
base: dev
Choose a base branch
from
+7 −1
Open

Improve devHelper warning for missing CustomParseFormat plugin #2982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95e30bc
devHelper: improve warning for missing CustomParseFormat plugin
Nov 26, 2025
b03be8f
Merge branch 'dev' of https://github.com/Albez0-An7h/dayjs into dev
Nov 26, 2025
41c9097
devHelper: improve warning for missing CustomParseFormat plugin
Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugin/devHelper/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export default (o, c, d) => {
if (typeof date === 'number' && String(date).length === 4) {
console.warn(`Guessing you may want to parse the Year ${date}, you should pass it as a String ${date}, not a Number. Otherwise, ${date} will be treated as a Unix timestamp`)
}
if (cfg.args.length >= 2 && !d.p.customParseFormat) {
if (cfg.args.length >= 2 && typeof cfg.args[1] === 'string' && !d.p.customParseFormat) {
console.warn(`To parse a date-time string like ${date} using the given format, you should enable customParseFormat plugin first. https://day.js.org/docs/en/parse/string-format`)
}
return oldParse.bind(this)(cfg)
Expand Down
6 changes: 6 additions & 0 deletions test/plugin/devHelper.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@ it('Warning Enable customParseFormat plugin while passing the second format para
expect(consoleSpy).toHaveBeenCalledWith('To parse a date-time string like 2020 using the given format, you should enable customParseFormat plugin first. https://day.js.org/docs/en/parse/string-format')
})

it('Warning Enable customParseFormat plugin for date with format string (MM/DD/YYYY)', () => {
const consoleSpy = jest.spyOn(console, 'warn')
dayjs('11/1/2004', 'MM/DD/YYYY')
expect(consoleSpy).toHaveBeenCalledWith('To parse a date-time string like 11/1/2004 using the given format, you should enable customParseFormat plugin first. https://day.js.org/docs/en/parse/string-format')
})

it('Warning: Setting locale before loading locale', () => {
const consoleSpy = jest.spyOn(console, 'warn')
dayjs.locale('zh-cn')
Expand Down