Skip to content

Commit 9211a54

Browse files
committed
address some more concerns
1 parent 748d0d2 commit 9211a54

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

proposals/2376-no-url-previews.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ is already obvious from the message itself.
55

66
## Proposal
77
This proposal adds a new attribute to the `formatted_body` key of messages with type
8-
`m.room.member` and msgtype `m.text`.
8+
`m.room.message` and msgtype `m.text`.
99

1010
It adds a new attribute, `data-mx-nopreview` to the `<a>` HTML tag. If this attribute is present the
1111
client SHOULD NOT display a URL preview.
@@ -22,12 +22,16 @@ client SHOULD NOT display a URL preview.
2222

2323
## Potential issues
2424
HTML tags are usually meant for formatting. Disabling URL previews isn't strictly formatting.
25-
However, as the client will already have parsed the tag in order to generate a URL preview the place
26-
seems appropriate.
25+
26+
Additionally, clients may currently only gather the URL previews only from the `body`, forcing them
27+
to parse the `formatted_body` as well.
2728

2829
## Alternatives
2930
A flag could be set for the entire message to disable URL previews, however that doesn't allow for
3031
having within a message one URL with preview and one without.
3132

33+
Alternatively, a new, optional, key `url_previews` with an array of the URLs to preview for could be
34+
introduced.
35+
3236
## Security considerations
3337
You could get tricked more easily into being Rickroll'd.

0 commit comments

Comments
 (0)