Skip to content

MSC3547: Allow appservice bot user to read any rooms the appservice is part of #3548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Half-Shot wants to merge 4 commits into
base: main
Choose a base branch
from
Open

MSC3547: Allow appservice bot user to read any rooms the appservice is part of #3548

Half-Shot wants to merge 4 commits into from

Conversation

@Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Dec 6, 2021 •
edited by github-actions bot
Loading

@Half-Shot Half-Shot added proposal A matrix spec change proposal proposal-pr application services client-server Client-Server API labels Dec 6, 2021
@turt2live turt2live added proposal-in-review kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. and removed proposal-pr client-server Client-Server API labels Dec 6, 2021
@Half-Shot Half-Shot changed the title MSC3547: Allow appservice bot user global read permissions MSC3547: Allow appservice bot user to read any rooms the appserice is part of Dec 6, 2021
deepbluev7
deepbluev7 reviewed Dec 6, 2021
View reviewed changes
@HarHarLinks
Copy link
Contributor

HarHarLinks commented Dec 10, 2021

Title typo: "appserice"

@Half-Shot Half-Shot changed the title MSC3547: Allow appservice bot user to read any rooms the appserice is part of MSC3547: Allow appservice bot user to read any rooms the appservice is part of Dec 10, 2021
Half-Shot
Half-Shot commented Dec 11, 2021
View reviewed changes
proposals/3547-appservice-global-read.md
user is part of, it doesn't change the security impact. It is already possible to read these events by determining
the membership in the target room, and masquerading as a user that has access.

## Unstable prefix
Copy link
Contributor Author

@Half-Shot Half-Shot Dec 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need this msc to be spelled out in /versions so clients know what behaviours to expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@deepbluev7 deepbluev7 deepbluev7 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

application services kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Half-Shot @HarHarLinks @deepbluev7 @turt2live