-
Notifications
You must be signed in to change notification settings - Fork 417
WIP: MSC4268: Sharing room keys for past messages #4268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This event is defined in MSC4268. MSC4268: matrix-org/matrix-spec-proposals#4268
This event is defined in MSC4268. MSC4268: matrix-org/matrix-spec-proposals#4268
This event is defined in MSC4268. MSC4268: matrix-org/matrix-spec-proposals#4268
This event is defined in MSC4268. MSC4268: matrix-org/matrix-spec-proposals#4268
|
|
||
| ### Room key bundle format | ||
|
|
||
| When Alice is about to invite Bob to a room, she first assembles a "room key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this imply that clients should have all the keys for the room locally for the room at the time of the invite?
I'm thinking of a client that doesn't download it's complete key storage on login, but instead lazily requests keys as needed from it's homeserver.
Should we be suggesting that clients should download their complete key storage at login? Or that clients that don't download all their keys at login should download all their keys prior to inviting someone using the existing GET /_matrix/client/v3/room_keys/keys/{roomId} endpoint?
Additionally, clients may need to defer sending the invite if they're currently catching up on a backlog of to_device events, and there might be a race where recent keys aren't available to the client when they would like to make the invite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should avoid making comments mid-Matrix Conference presentations, lest they be answered in later slides.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol 😁 For those following at home, the answer to both questions is "yes", and this might be worth calling out in the text of the MSC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(FWIW we do think that clients should be downloading their complete key storage at login, to guard against key loss due to a storage reset operation: element-hq/element-meta#2446)
A proposal for sharing the keys to existing room messages when inviting someone to a room.
This reintroduces the functionality previously proposed in MSC3061.
Conflict of Interest declaration: I am employed by Element. This MSC was written as part of my work on the Element Cryptography team.
Rendered