-
Notifications
You must be signed in to change notification settings - Fork 395
Open
Labels
metaSomething concerning the repo itself, such as technical changes, contribution guidelines, and more.Something concerning the repo itself, such as technical changes, contribution guidelines, and more.
Description
matrix.org/.github/pull_request_template.md
Lines 1 to 10 in 0465d91
| <!-- Thank you for creating a Pull Request to the matrix.org website! | |
| Please read our documentation for contributors to make the review process a smooth as possible: | |
| - https://github.com/matrix-org/matrix.org/blob/main/README.md | |
| - https://github.com/matrix-org/matrix.org/blob/main/CONTRIBUTING.md | |
| - https://github.com/matrix-org/matrix.org/blob/main/CONTENT.md | |
| You can use the CI build or a local environment to check your changes are working as expected. | |
| If you have questions at any time, please contact the Website & Content Working Group at | |
| https://matrix.to/#/#matrix.org-website:matrix.org --> |
Move to the bottom of the template
matrix.org/.github/pull_request_template.md
Lines 21 to 22 in 0465d91
| - [ ] Wrap plain URLs in `<>` to linkify them ([learn more](https://github.com/matrix-org/matrix.org/blob/main/CONTENT.md#publishing-to-the-blog)). | |
| - [ ] Use the right level of headings: The page title will use a level 1 headings, so your headings should use level 2 and below. |
We want to convert these into CI checks using rumdl
| - [ ] Use internal links: when linking to another page on <https://matrix.org>, use the Zola `[label](@/target.md)` [syntax](https://www.getzola.org/documentation/content/linking/#internal-links). |
Move to CONTENT.md but only check as reviewer
matrix.org/.github/pull_request_template.md
Lines 13 to 26 in 0465d91
| <!-- Please describe what you added here, and add a screenshot or video if possible. | |
| That makes it easier to understand the change. --> | |
| ### :heavy_check_mark: Checklist | |
| <!-- Please tick as appropriate, but don't remove this checklist from your PR, as it is useful for reviewers, too. --> | |
| - [x] Keep this checklist | |
| - Check for common mistakes: | |
| - [ ] Wrap plain URLs in `<>` to linkify them ([learn more](https://github.com/matrix-org/matrix.org/blob/main/CONTENT.md#publishing-to-the-blog)). | |
| - [ ] Use the right level of headings: The page title will use a level 1 headings, so your headings should use level 2 and below. | |
| - [ ] Use internal links: when linking to another page on <https://matrix.org>, use the Zola `[label](@/target.md)` [syntax](https://www.getzola.org/documentation/content/linking/#internal-links). | |
| - For blog posts: | |
| - [ ] Verify the date and post ordering on the `/blog` page, especially for multiple posts on the same day. Prefer UTC format, e.g. `2025-12-01T14:00:00Z` for Dec 1st, 2025, 2pm UTC. | |
| - [ ] Set the correct author and category. Browse existing ones at <https://matrix.org/author/> and <https://matrix.org/category/> to match them. |
also move to CONTENT.md
matrix.org/.github/pull_request_template.md
Lines 27 to 29 in 0465d91
| - [ ] If you hold a specific role in relation to the content you are contributing, such as project maintainer or on behalf of a team or organisation, please let us know. See [example](https://github.com/matrix-org/matrix.org/pull/2969). | |
| - [ ] If your PR is time-sensitive in any way, please mention the attached timeline and context in the PR description. | |
| - [ ] Mention any issues related to the PR. Use [GitHub keywords](https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) as appropriate. |
Convert to sections similar to description
make sure the PR bot CI still has something to match, but also change the match to something that actually needs to stay, not some comment.
Metadata
Metadata
Assignees
Labels
metaSomething concerning the repo itself, such as technical changes, contribution guidelines, and more.Something concerning the repo itself, such as technical changes, contribution guidelines, and more.