-
Notifications
You must be signed in to change notification settings - Fork 36.7k
Show the Learn How to Hide AI Features in more situations (fix #268450)
#268462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes issue #268450 by making the "Learn How to Hide AI Features" action available in more situations by removing a restrictive precondition.
- Removes the requirement that chat setup must not be installed for the hide action to be available
- Simplifies the precondition to only check that chat setup is not already hidden
|
/assign @isidorn |
π¬ CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
|
See #268450 (comment) for my verification that this PR only affects Command Palette visibility of this command. Please consider approving it. |
isidorn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for trying it out. Having this in the command palette makes sense. I can also verify this once it hits the insiders build the day after
|
Thanks @isidorn. Please allow workflows to run, and set it to auto merge. |
|
@isidorn please approve the workflows to run once more. I merged main into this branch as a way of getting the license/cla check to succeed (which it did), but now need other workflows approving. |
Tyriar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @bpasero
This PR fixes #268450