Skip to content

Conversation

@gjsjohnmurray
Copy link
Contributor

This PR fixes #268450

Copilot AI review requested due to automatic review settings September 26, 2025 11:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issue #268450 by making the "Learn How to Hide AI Features" action available in more situations by removing a restrictive precondition.

  • Removes the requirement that chat setup must not be installed for the hide action to be available
  • Simplifies the precondition to only check that chat setup is not already hidden

@gjsjohnmurray
Copy link
Contributor Author

/assign @isidorn

@vs-code-engineering
Copy link

vs-code-engineering bot commented Oct 20, 2025

πŸ“¬ CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

  • src/vs/workbench/contrib/chat/browser/chatSetup.ts

@gjsjohnmurray
Copy link
Contributor Author

See #268450 (comment) for my verification that this PR only affects Command Palette visibility of this command. Please consider approving it.

Copy link
Collaborator

@isidorn isidorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for trying it out. Having this in the command palette makes sense. I can also verify this once it hits the insiders build the day after

@isidorn isidorn added this to the October 2025 milestone Oct 21, 2025
@gjsjohnmurray
Copy link
Contributor Author

Thanks @isidorn. Please allow workflows to run, and set it to auto merge.

@isidorn isidorn enabled auto-merge October 21, 2025 12:37
@gjsjohnmurray
Copy link
Contributor Author

@isidorn please approve the workflows to run once more. I merged main into this branch as a way of getting the license/cla check to succeed (which it did), but now need other workflows approving.

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @bpasero

@isidorn isidorn merged commit 0734942 into microsoft:main Oct 22, 2025
17 checks passed
@gjsjohnmurray gjsjohnmurray deleted the fix-268450 branch October 22, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command Chat: Learn How to Hide AI Features is missing from Command Palette

4 participants