BICAWS7-3900-convert-cxe01-to-leds #1714
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emadkaramad
previously approved these changes
Dec 2, 2025
emadkaramad
reviewed
Dec 3, 2025
| units = "life" | ||
| } else { | ||
| count = Number(quantity.slice(1, 4).trim()) || 0 | ||
| const unitMap: Record<string, DisposalDurationUnit> = { |
Collaborator
There was a problem hiding this comment.
Nitpick: This constant can be moved outside of the function at the top.
emadkaramad
previously approved these changes
Dec 3, 2025
… every offence schema
emadkaramad
force-pushed
the
BICAWS7-3900-convert-cxe01-to-leds
branch
from
60530e0 to
f407e1b
Compare
tausifpatel
force-pushed
the
BICAWS7-3900-convert-cxe01-to-leds
branch
from
1e26a00 to
3b41b15
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a helper function that converts a PNC response JSON into the LEDS response JSON format.
The purpose of this addition is to enable running the existing end to end tests for LEDS by reusing responses created for PNC.