Improved pull request "Files Changed" experience feedback #163932
Replies: 2311 comments 814 replies
-
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
Beta Was this translation helpful? Give feedback.
-
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
Beta Was this translation helpful? Give feedback.
-
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
Beta Was this translation helpful? Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
Beta Was this translation helpful? Give feedback.
-
|
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
Beta Was this translation helpful? Give feedback.
-
|
This is so much better, I might go back from reviewing with the VSCode extension now π I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
Beta Was this translation helpful? Give feedback.
-
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
|
The tab for |
Beta Was this translation helpful? Give feedback.
-
|
Not sure if this is the sort of feedback you're after, but the |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
On the Files changed tab I can only see 19 files out of 66. Why? |
Beta Was this translation helpful? Give feedback.
-
|
I used to be able to click on a useful link to see the submodule diff in PRs but now its just plain text. Could we have that back pls? |
Beta Was this translation helpful? Give feedback.
-
|
It doesn't always seem to remember if hide whitespace was turned on. |
Beta Was this translation helpful? Give feedback.
-
|
For file renames with long paths, there doesn't seem to be a way to reveal the original file name. The path is truncated to just the end of the new file name and the path link alt test only includes the new file name. The only indication that it was even renamed is the orange icon in the file tree: |
Beta Was this translation helpful? Give feedback.
-
|
Found another one... after a
|
Beta Was this translation helpful? Give feedback.
-
|
Sorry if this was already pointed out above, but it appears that it's no longer possible to submit a review with replies only and no top-level comment. That is the preferred model in our team (over leaving replies one by one) to avoid spamming everyone subscribed to the PR with emails or notifications. |
Beta Was this translation helpful? Give feedback.
-
|
We have a PR with only 69 changed files, and we get the notification:
This wouldn't be an issue if the sidebar kept track of which files are marked as viewed, but now I have to always go through the files one by one to see if I've missed anything while jumping from file to file. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Can I customize the destination URL for the new 'View Details' button within annotations? If so, where can I find the documentation for this feature? |
Beta Was this translation helpful? Give feedback.
-
|
The new view works very well for me. But I noticed that when I disabled "Viewed files" within the file tree and then hit the "Reload" button (the one which appears when externel changes are detected). This one gets enabled again. This does not happen when reloading the page via F5. BTW whats still missing is a one click way to reset the viewed stat of all files. This would help especially before merge to do a full review again. |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
The new view works really well in almost all scenarios. I have noticed one where it is extremely slow, to the point that I need to switch back to the classic view to complete my PR reviews. In TypeScript projects that use the Yarn zero-installs pattern, it is not uncommon to have hundreds of files in the yarn cache in a PR. This generally isn't a problem. GitHub shows them as binary files and I can filter out the If I switch back to classic view, I am able to filter out and review the remaining files in the same PR pretty much instantly. |
Beta Was this translation helpful? Give feedback.
-
|
I work in open standards and open-source, and I'm hoping you can revisit your decision to limit to only displaying the first 40 comments and look to increase it soon. As an example, within the glTF repository it's not uncommon for PRs to have far more than 40 comments. These discussions are often long running and vital to ensuring we get things correct, so marking the discussions as "resolved" is not a solution for us. Can you please provide us with a way of better handling this? As it is right now, only displaying the first 40 comments makes the new "Files Changed" experience useless for many of these large PRs. While the old method was slow and had its own limits, there are some clear examples where the old experience can show comments when the new experience is unable. This is most egregious on this very large PR, where these errors in both experiences are problematic. New Experience
Classic Experience
|
Beta Was this translation helpful? Give feedback.
-
|
probably already mentioned here, but (this is a hard format to look at previous comments) likes:
dislikes:
|
Beta Was this translation helpful? Give feedback.
-
|
I don't like the following in the new "Comments" panel.
I don't like in the diff how the comments don't show up inline -- only tiny avatar circles on the right side / not searchable if I try to find everywhere with someone's name. Not sure if this has been fixed, but I got a ton of errors when trying to comment on multiple lines. Something like "End line number cannot be less than the start number". But all I did was use your UI to select the lines I wanted to comment on. I had to cancel my comment, reload the page, and switch to commenting on a single line instead of the range I actually wanted. |
Beta Was this translation helpful? Give feedback.
-
|
I don't like it that it's only showing one modified file at a time. Makes it very clumsy to review the PR, especially when you want to review multiple files at the same time because there are dependencies between these files. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Our code review process requires reviewers to leave
|
Beta Was this translation helpful? Give feedback.



























Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Important
You can opt in to the public preview from any pull request via
β¨Try the new experiencein the upper-right corner. You can return to the classic view by clicking the βswitch backβ link.About the new experience
This refresh focuses on performance, accessibility, and clarity so reviews stay responsiveβeven on the largest pull requests.
Whatβs new ?
Performance π
UX β¨
Accessibility
What's missing? π¨
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, weβre increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experienceβwe read every comment!
Beta Was this translation helpful? Give feedback.
All reactions