Set FPM log level earlier during init #894
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The log level will be ignored throughout log events in fpm_unix_init_main, until the very end when zlog_set_level is finally called. In particular, fpm_unix_conf_wp may throw notices like this: > [08-Nov-2014 17:13:36] NOTICE: [pool www] 'user' directive is ignored when… Which will still appear even if log_level in php-fpm.conf is set to warning+
Member
|
@dzuelke can you please close this PR (as it is merged, and don't have enough right here) |
|
Comment on behalf of remi at php.net: merged |
dzuelke
added a commit
to dzuelke/php-src
that referenced
this pull request
Nov 19, 2014
from fpm_unix_init_main() to fpm_conf_post_process() this time (see php#894), because otherwise nothing in fpm_conf_init_main() obeys log levels
php-pulls
pushed a commit
that referenced
this pull request
Nov 20, 2014
from fpm_unix_init_main() to fpm_conf_post_process() this time (see #894), because otherwise nothing in fpm_conf_init_main() obeys log levels
php-pulls
pushed a commit
that referenced
this pull request
Nov 20, 2014
from fpm_unix_init_main() to fpm_conf_post_process() this time (see #894), because otherwise nothing in fpm_conf_init_main() obeys log levels
php-pulls
pushed a commit
that referenced
this pull request
Nov 21, 2014
from fpm_unix_init_main() to fpm_conf_post_process() this time (see #894), because otherwise nothing in fpm_conf_init_main() obeys log levels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log level will be ignored throughout log events in
fpm_unix_init_main, untilthe very end when
zlog_set_levelis finally called.In particular,
fpm_unix_conf_wpmay throw notices like this:Which will still appear even if
log_levelin php-fpm.conf is set towarning+To reproduce, set "log_level" in
php-fpm.confto warning. On startup as non-root, these two notices will still appear:Adresses https://bugs.php.net/bug.php?id=68381