Skip to content

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Jul 29, 2023

Clinic objects are only ever created in one place in clinic.py, and the filename parameter is passed an object that we know to be a string:

clinic = Clinic(language, verify=verify, filename=filename)

There's no need for this parameter to be optional. By making it required, we can remove an ugly assertion elsewhere that we added to keep mypy happy.

@AlexWaygood AlexWaygood merged commit 6c74b2f into python:main Jul 29, 2023
@AlexWaygood AlexWaygood deleted the clinic-required-params branch July 29, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants