Skip to content

GH-128682: Account for escapes in DECREF_INPUTS #129953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 19 commits into from
Feb 12, 2025
Merged

GH-128682: Account for escapes in DECREF_INPUTS #129953

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
8fc5562
Refactor cast_type
markshannon Feb 4, 2025
e9253ee
Handle escapes in DECREF_INPUTS
markshannon Feb 5, 2025
d394c7a
Merge branch 'main' into account-for-escapes-in-decref-inputs
markshannon Feb 5, 2025
de9adc3
Escape around final close
markshannon Feb 6, 2025
f62123f
Set var to NULL whenever there are multiple values to close
markshannon Feb 6, 2025
d09e18b
Add output filter to remove spill/reload pairs
markshannon Feb 7, 2025
17b3e16
Mark a few more functions as escaping
markshannon Feb 7, 2025
1e51c54
Merge branch 'main' into account-for-escapes-in-decref-inputs
markshannon Feb 7, 2025
c7d3f09
Replace DECREF_INPUTS with PyStackRef_CLOSE where possible
markshannon Feb 7, 2025
534b694
Merge branch 'main' into account-for-escapes-in-decref-inputs
markshannon Feb 10, 2025
96b88ea
Add news
markshannon Feb 10, 2025
98e5c1d
Add missing type annotation
markshannon Feb 10, 2025
dfe076e
Tidy up
markshannon Feb 10, 2025
4489850
Attempt to silence MyPy
markshannon Feb 10, 2025
6a993e0
Add another spill in a macro
markshannon Feb 10, 2025
68f820f
Pacify mypy so it doesn't complain about yet another false positive
markshannon Feb 12, 2025
885ffe8
Turn off assert for free-threading
markshannon Feb 12, 2025
76001f7
_PyLong_Add/Multiply/Subtract can escape for large numbers
markshannon Feb 12, 2025
ca74e2e
Merge branch 'main' into account-for-escapes-in-decref-inputs
markshannon Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add news
  • Loading branch information
@markshannon
markshannon committed Feb 10, 2025
commit 96b88ea69ef6cc50e7e58357832fdc6c2da643ac
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2025-02-10-11-30-13.gh-issue-129953.wipsl_.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
The internal (evaluation) stack is now spilled to memory whenever execution
esacpes from the interpreter or JIT compiled code. This should have no
observable effect in either Python or builtin extensions, but will allow
various important optimizations in the future.
Loading