Skip to content

gh-133701: Fix incorrect __annotations__ on TypedDict defined under PEP 563 #133772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JelleZijlstra merged 1 commit into from
May 14, 2025
Merged

gh-133701: Fix incorrect __annotations__ on TypedDict defined under PEP 563 #133772

JelleZijlstra merged 1 commit into from
May 14, 2025

Conversation

@JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented May 9, 2025 •
edited by bedevere-app bot
Loading

@JelleZijlstra JelleZijlstra requested a review from AlexWaygood as a code owner May 9, 2025 15:50
@bedevere-app bedevere-app bot mentioned this pull request May 9, 2025
Closed
@JelleZijlstra JelleZijlstra added the needs backport to 3.14 bugs and security fixes label May 9, 2025
This was referenced May 9, 2025
Closed
Closed
@JelleZijlstra JelleZijlstra merged commit 9836503 into python:main May 14, 2025
43 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented May 14, 2025

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 14, 2025
@JelleZijlstra @miss-islington
pythongh-133701: Fix incorrect __annotations__ on TypedDict defined…
f570053 
… under PEP 563 (pythonGH-133772)

(cherry picked from commit 9836503)

Co-authored-by: Jelle Zijlstra <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented May 14, 2025

GH-134003 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 14, 2025
JelleZijlstra added a commit that referenced this pull request May 14, 2025
@miss-islington @JelleZijlstra
[3.14] gh-133701: Fix incorrect __annotations__ on TypedDict define…
d6cb8fa 
…d under PEP 563 (GH-133772) (#134003)

gh-133701: Fix incorrect `__annotations__` on TypedDict defined under PEP 563 (GH-133772)
(cherry picked from commit 9836503)

Co-authored-by: Jelle Zijlstra <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 24, 2025
Merged
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@JelleZijlstra @Pranjal095
pythongh-133701: Fix incorrect __annotations__ on TypedDict defined…
2db0675 
… under PEP 563 (python#133772)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@JelleZijlstra @taegyunkim
pythongh-133701: Fix incorrect __annotations__ on TypedDict defined…
497193f 
… under PEP 563 (python#133772)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JelleZijlstra