Skip to content

Deno.env review/cleanup: no set() past startup #12621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cscheid wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Deno.env review/cleanup: no set() past startup #12621

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
caa8cc1
do not use Deno.env.set indiscriminately to avoid races
cscheid Apr 24, 2025
9626fd3
do not use Deno.env.set, instead pass env to subprocess invocation calls
cscheid Apr 24, 2025
71bf433
merge
cscheid May 13, 2025
f320f5f
Merge branch 'main' into bugfix/no-env-set-past-startup
cscheid May 21, 2025
38bfd73
add required field
cscheid May 21, 2025
6d55dcc
more type fixes
cscheid May 21, 2025
bc77de7
fix typo
cscheid May 21, 2025
6028e0b
send environment to jupyter, add tests
cscheid May 21, 2025
9a66d2a
Merge branch 'main' into bugfix/no-env-set-past-startup
cscheid Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into bugfix/no-env-set-past-startup
  • Loading branch information
@cscheid
cscheid committed Jun 16, 2025
commit 9a66d2ad20ba9fe564d6c54f6af3b240bd476167

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.