Increase bootstrap reliability by not filtering out extra cran url #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbast
commented
Jan 18, 2021
tests/testthat/test-bootstrap.R
Outdated
| renv_scope_options(repos = c(CRAN = "https://broken_url")) | ||
|
|
||
| library <- renv_libpaths_default() | ||
| bootstrap(version = "1.0.0", library = library) |
Contributor
Author
There was a problem hiding this comment.
Version="1.0.0" is a local version and should be changed to a cran available version like 0.12.3 to actually download from cran. But that seems to be not possible during the tests?
Collaborator
There was a problem hiding this comment.
renv sets up its own local CRAN-like repository with "fake" versions of packages available, and those should be used during testing.
(Relying on CRAN itself means tests will fail intermittently if internet connectivity is spotty on the CRAN machines, which we do not want)
Contributor
Author
There was a problem hiding this comment.
Ok, will then remove the test case, as the changed code is not testable that way.
Anything else to change/do? Any comment to the actual changed code? Thanks
Rename default extra cran url key to ensure it is not filtered out by the repo URL deduplication code. It is thus always there as fallback in cases where the cran url points to a server which is not available, outdated or broken.
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename default extra cran url key to ensure it is not filtered out by the
repo URL deduplication code. It is thus always there as fallback in cases
where the cran url points to a server which is not available, outdated or
broken.