Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: serde-rs/serde
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.145
Choose a base ref
...
head repository: serde-rs/serde
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.147
Choose a head ref
  • 16 commits
  • 15 files changed
  • 4 contributors

Commits on Sep 23, 2022

  1. Configuration menu
    Copy the full SHA
    b267634 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    649a72a View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Configuration menu
    Copy the full SHA
    3ffb86f View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2022

  1. Resolve uninlined_format_args pedantic clippy lint in test suite

        error: variables can be used directly in the `format!` string
            --> test_suite/tests/test_annotations.rs:1238:30
             |
        1238 |     serializer.serialize_str(format!("{};{:?}", f1, f2).as_str())
             |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^
             |
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
             = note: `-D clippy::uninlined-format-args` implied by `-D clippy::pedantic`
        help: change this to
             |
        1238 -     serializer.serialize_str(format!("{};{:?}", f1, f2).as_str())
        1238 +     serializer.serialize_str(format!("{f1};{f2:?}").as_str())
             |
    dtolnay committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    d96e181 View commit details
    Browse the repository at this point in the history
  2. Ignore uninlined_format_args pedantic clippy lint false positive

    Clippy's suggested fix is not valid in 2018 edition. The
    serde_test_suite crate can't be updated to 2021 edition yet because CI
    of the serde crate on old toolchains needs to be able to parse all
    manifests in the workspace, even if serde_test_suite is not being
    compiled in those builds.
    
        error: variables can be used directly in the `format!` string
            --> test_suite/tests/test_de.rs:2260:23
             |
        2260 |             Err(e) => panic!("tokens failed to deserialize: {}", e),
             |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
             |
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
             = note: `-D clippy::uninlined-format-args` implied by `-D clippy::pedantic`
        help: change this to
             |
        2260 -             Err(e) => panic!("tokens failed to deserialize: {}", e),
        2260 +             Err(e) => panic!("tokens failed to deserialize: {e}"),
             |
    
        warning: unused variable: `e`
            --> test_suite/tests/test_de.rs:2260:17
             |
        2260 |             Err(e) => panic!("tokens failed to deserialize: {e}"),
             |                 ^ help: if this is intentional, prefix it with an underscore: `_e`
             |
             = note: `#[warn(unused_variables)]` on by default
    
        warning: panic message contains an unused formatting placeholder
            --> test_suite/tests/test_de.rs:2260:61
             |
        2260 |             Err(e) => panic!("tokens failed to deserialize: {e}"),
             |                                                             ^^^
             |
             = note: this message is not used as a format string when given without arguments, but will be in Rust 2021
             = note: `#[warn(non_fmt_panics)]` on by default
        help: add the missing argument
             |
        2260 |             Err(e) => panic!("tokens failed to deserialize: {e}", ...),
             |                                                                 +++++
        help: or add a "{}" format string to use the message literally
             |
        2260 |             Err(e) => panic!("{}", "tokens failed to deserialize: {e}"),
             |                              +++++
    dtolnay committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    f803b29 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Configuration menu
    Copy the full SHA
    07696c1 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2297 from serde-rs/output

    Switch from set-output to $GITHUB_OUTPUT
    dtolnay authored Oct 13, 2022
    Configuration menu
    Copy the full SHA
    55cf0ac View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Serialize and deserialize a tagged newtype variant over unit () as if…

    … it was a unit variant.
    tage64 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    90d28fc View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. Update test_suite/tests/test_annotations.rs

    Co-authored-by: David Tolnay <[email protected]>
    tage64 and dtolnay authored Oct 21, 2022
    Configuration menu
    Copy the full SHA
    a07d794 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e2ccfd9 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2303 from tage64/master

    Serialize and deserialize a tagged newtype variant over unit () as if it was a unit variant
    dtolnay authored Oct 21, 2022
    Configuration menu
    Copy the full SHA
    6aed101 View commit details
    Browse the repository at this point in the history
  4. Touch up PR 2303

    dtolnay committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    142dce0 View commit details
    Browse the repository at this point in the history
  5. Release 1.0.146

    dtolnay committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    3fd8e52 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    354b48f View commit details
    Browse the repository at this point in the history
  7. Merge pull request #2305 from serde-rs/enumaccessdeserializer

    Add EnumAccessDeserializer to turn EnumAccess into a Deserializer
    dtolnay authored Oct 21, 2022
    Configuration menu
    Copy the full SHA
    6d00971 View commit details
    Browse the repository at this point in the history
  8. Release 1.0.147

    dtolnay committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    f415092 View commit details
    Browse the repository at this point in the history
Loading