-
-
Notifications
You must be signed in to change notification settings - Fork 870
Comparing changes
Open a pull request
base repository: serde-rs/serde
base: v1.0.145
head repository: serde-rs/serde
compare: v1.0.147
- 16 commits
- 15 files changed
- 4 contributors
Commits on Sep 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b267634 - Browse repository at this point
Copy the full SHA b267634View commit details -
Configuration menu - View commit details
-
Copy full SHA for 649a72a - Browse repository at this point
Copy the full SHA 649a72aView commit details
Commits on Oct 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3ffb86f - Browse repository at this point
Copy the full SHA 3ffb86fView commit details
Commits on Oct 8, 2022
-
Resolve uninlined_format_args pedantic clippy lint in test suite
error: variables can be used directly in the `format!` string --> test_suite/tests/test_annotations.rs:1238:30 | 1238 | serializer.serialize_str(format!("{};{:?}", f1, f2).as_str()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: `-D clippy::uninlined-format-args` implied by `-D clippy::pedantic` help: change this to | 1238 - serializer.serialize_str(format!("{};{:?}", f1, f2).as_str()) 1238 + serializer.serialize_str(format!("{f1};{f2:?}").as_str()) |Configuration menu - View commit details
-
Copy full SHA for d96e181 - Browse repository at this point
Copy the full SHA d96e181View commit details -
Ignore uninlined_format_args pedantic clippy lint false positive
Clippy's suggested fix is not valid in 2018 edition. The serde_test_suite crate can't be updated to 2021 edition yet because CI of the serde crate on old toolchains needs to be able to parse all manifests in the workspace, even if serde_test_suite is not being compiled in those builds. error: variables can be used directly in the `format!` string --> test_suite/tests/test_de.rs:2260:23 | 2260 | Err(e) => panic!("tokens failed to deserialize: {}", e), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: `-D clippy::uninlined-format-args` implied by `-D clippy::pedantic` help: change this to | 2260 - Err(e) => panic!("tokens failed to deserialize: {}", e), 2260 + Err(e) => panic!("tokens failed to deserialize: {e}"), | warning: unused variable: `e` --> test_suite/tests/test_de.rs:2260:17 | 2260 | Err(e) => panic!("tokens failed to deserialize: {e}"), | ^ help: if this is intentional, prefix it with an underscore: `_e` | = note: `#[warn(unused_variables)]` on by default warning: panic message contains an unused formatting placeholder --> test_suite/tests/test_de.rs:2260:61 | 2260 | Err(e) => panic!("tokens failed to deserialize: {e}"), | ^^^ | = note: this message is not used as a format string when given without arguments, but will be in Rust 2021 = note: `#[warn(non_fmt_panics)]` on by default help: add the missing argument | 2260 | Err(e) => panic!("tokens failed to deserialize: {e}", ...), | +++++ help: or add a "{}" format string to use the message literally | 2260 | Err(e) => panic!("{}", "tokens failed to deserialize: {e}"), | +++++Configuration menu - View commit details
-
Copy full SHA for f803b29 - Browse repository at this point
Copy the full SHA f803b29View commit details
Commits on Oct 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 07696c1 - Browse repository at this point
Copy the full SHA 07696c1View commit details -
Merge pull request #2297 from serde-rs/output
Switch from set-output to $GITHUB_OUTPUT
Configuration menu - View commit details
-
Copy full SHA for 55cf0ac - Browse repository at this point
Copy the full SHA 55cf0acView commit details
Commits on Oct 20, 2022
-
Serialize and deserialize a tagged newtype variant over unit () as if…
… it was a unit variant.
Configuration menu - View commit details
-
Copy full SHA for 90d28fc - Browse repository at this point
Copy the full SHA 90d28fcView commit details
Commits on Oct 21, 2022
-
Update test_suite/tests/test_annotations.rs
Co-authored-by: David Tolnay <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a07d794 - Browse repository at this point
Copy the full SHA a07d794View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2ccfd9 - Browse repository at this point
Copy the full SHA e2ccfd9View commit details -
Merge pull request #2303 from tage64/master
Serialize and deserialize a tagged newtype variant over unit () as if it was a unit variant
Configuration menu - View commit details
-
Copy full SHA for 6aed101 - Browse repository at this point
Copy the full SHA 6aed101View commit details -
Configuration menu - View commit details
-
Copy full SHA for 142dce0 - Browse repository at this point
Copy the full SHA 142dce0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fd8e52 - Browse repository at this point
Copy the full SHA 3fd8e52View commit details -
Configuration menu - View commit details
-
Copy full SHA for 354b48f - Browse repository at this point
Copy the full SHA 354b48fView commit details -
Merge pull request #2305 from serde-rs/enumaccessdeserializer
Add EnumAccessDeserializer to turn EnumAccess into a Deserializer
Configuration menu - View commit details
-
Copy full SHA for 6d00971 - Browse repository at this point
Copy the full SHA 6d00971View commit details -
Configuration menu - View commit details
-
Copy full SHA for f415092 - Browse repository at this point
Copy the full SHA f415092View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.0.145...v1.0.147