Skip to content

Conversation

@malcolmbarrett
Copy link
Contributor

@malcolmbarrett malcolmbarrett commented Apr 1, 2018

The geom_rect and geom_tile doc examples include an aesthetic parameter for width, but neither geom has that, so the examples produce this warning:

ggplot(df, aes(x, y)) +
  geom_tile(aes(fill = z, width = w), colour = "grey50")

# > Warning: Ignoring unknown parameters: width

For geom_tile, I moved height and width over to default_aes. For geom_rect, though, I just removed width = w from the example in the docs because it seemed like a mistake (since geom_rect calculates width from xmin and xmax).

Thanks!
Malcolm

@hadley hadley closed this in a11f786 May 1, 2018
hadley added a commit that referenced this pull request May 1, 2018
And remove unneeded width aesthetic. Part of #2510
@hadley
Copy link
Member

hadley commented May 1, 2018

Thanks! I ended up merging by hand so I could add a unit test too.

@lock
Copy link

lock bot commented Oct 29, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Oct 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants