Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: timholy/Revise.jl
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.7.6
Choose a base ref
...
head repository: timholy/Revise.jl
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.8.0
Choose a head ref
  • 12 commits
  • 18 files changed
  • 2 contributors

Commits on May 19, 2025

  1. remove no-longer necessary moduledeps data structure (#916)

    This data structure was added in 32f8727,
    but its functionality has since been provided by LoweredCodeUtils and is
    no longer needed. This removes all code related to `moduledeps` and clean up.
    aviatesk authored May 19, 2025
    Configuration menu
    Copy the full SHA
    4a0570d View commit details
    Browse the repository at this point in the history
  2. some minor refactoring on methods_by_execution! (#917)

    Separate functions based on what they return.
    aviatesk authored May 19, 2025
    Configuration menu
    Copy the full SHA
    d9aecc2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    830de99 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2025

  1. Configuration menu
    Copy the full SHA
    4e51d12 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a335cf6 View commit details
    Browse the repository at this point in the history
  3. simplify the interface to support non .jl files

    The interface added in #680 for supporting non-.jl
    files assumes usages of custom struct, which requires overloading
    functions like `abspath` and is therefore quite cumbersome.
    Worse still, that makes it harder to refactor Revise code base, since
    now we need to think about the possibility of arbitrary types in places
    that originally needed to handle `AbstractString`.
    
    This commit provides a simpler interface: support custom files by
    registering parsers per file extension in
    `Revise.parsers::Dict{String,Any}`.
    The greatly simplified `non_jl_test.jl` demonstrates how much more
    straightforward this approach is.
    Of course, a potential downside is that if multiple packages register
    different parsers for the same extension, conflicts could arise, but
    since this feature is experimental, I believe we don’t need to account
    for that scenario yet.
    aviatesk committed May 21, 2025
    Configuration menu
    Copy the full SHA
    2f11cda View commit details
    Browse the repository at this point in the history

Commits on May 22, 2025

  1. remove the interface for supporting non-jl files

    Remove interface for supporting non-.jl files introduced in #680.
    This interface forces functions that used to handle only `AbstractString`
    to deal with arbitrary types, making refactoring across the Revise.jl
    codebase difficult.
    The simplified interface proposed in the previous commit is also
    fragile since it relies on initialization and runtime-mutable data
    structures, and so it is therefore not a complete solution.
    After discussion, and since this experimental interface has effectively
    no users, we remove it for now to enable codebase refactoring until
    it becomes necessary again.
    aviatesk committed May 22, 2025
    Configuration menu
    Copy the full SHA
    f63d897 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0ea7485 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #921 from timholy/avi/simple-non-jl

    remove the interface to support non .jl files
    aviatesk authored May 22, 2025
    Configuration menu
    Copy the full SHA
    e47b794 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2025

  1. fix docs build (#923)

    aviatesk authored May 23, 2025
    Configuration menu
    Copy the full SHA
    3ab981a View commit details
    Browse the repository at this point in the history
  2. some more minor cleanups on the code base (#922)

    Separated from the refactoring I'm working on locally.
    aviatesk authored May 23, 2025
    Configuration menu
    Copy the full SHA
    2911b1e View commit details
    Browse the repository at this point in the history

Commits on May 27, 2025

  1. 2 Configuration menu
    Copy the full SHA
    92cb6b8 View commit details
    Browse the repository at this point in the history
Loading