ICU-23155 Fix buffer overflow in SSearchTest::offsetTest() #3546
+31
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://unicode-org.atlassian.net/browse/ICU-23155 Use std::string instead. Root cause analysis: In printOffsets, while the pointer `s` is advanced, the remaining size `n` remains unchanged to be a constant 4096, and snprintf falsely thinks the buffer has 4096 bytes left.
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
gvictor
changed the title
Collaborator
Author
|
@markusicu can you help review this test change? |
roubert
reviewed
Nov 8, 2025
| } | ||
|
|
||
| static char *printOffsets(char *buffer, size_t n, OrderList &list) | ||
| static char* printOffsets(std::string &buffer, OrderList &list) |
Member
There was a problem hiding this comment.
This would all become considerably simpler if the caller wasn't required to pass in any buffer at all and the function simply returned an std::string object by value. That's what any normal C++ code would do nowadays.
roubert
requested changes
Nov 8, 2025
| int32_t size = list.size(); | ||
| char *s = buffer; | ||
| buffer.clear(); | ||
| buffer.reserve(size * 10 + 2); |
Member
There was a problem hiding this comment.
Is this some kind of performance optimization, to avoid having to dynamically resize the buffer? If so, I suggest removing it, this is test code, the possible performance gain is irrelevant compared to having a few extra lines of code to maintain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://unicode-org.atlassian.net/browse/ICU-23155
Use std::string instead.
Root cause analysis:
In printOffsets, while the pointer
sis advanced, the remaining sizenremains unchanged to be a constant 4096, and snprintf falsely thinks the buffer has 4096 bytes left.Checklist