Skip to content

ICU-23252 Fix int overflow in messagepattern.cpp #3762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FrankYFTang merged 1 commit into from
Nov 5, 2025
Merged

ICU-23252 Fix int overflow in messagepattern.cpp #3762

FrankYFTang merged 1 commit into from
Nov 5, 2025
+21 −2

Conversation

@FrankYFTang
Copy link
Contributor

@FrankYFTang FrankYFTang commented Nov 4, 2025 •
edited
Loading

Checklist

  • Required: Issue filed: ICU-23252
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable
  • Approver: Feel free to merge on my behalf

markusicu
markusicu reviewed Nov 4, 2025
View reviewed changes
@markusicu markusicu self-assigned this Nov 4, 2025
@FrankYFTang
Copy link
Contributor Author

FrankYFTang commented Nov 4, 2025

PTAL

@FrankYFTang FrankYFTang requested a review from markusicu November 4, 2025 22:39
markusicu
markusicu previously approved these changes Nov 4, 2025
View reviewed changes
FrankYFTang added a commit to FrankYFTang/icu that referenced this pull request Nov 4, 2025
@FrankYFTang
ICU-23252 Fix int overflow in messagepattern.cpp
da4a81a 
See unicode-org#3762
@FrankYFTang FrankYFTang force-pushed the ICU-23252FixIntOverflowInMsgFmt branch from 713a8d7 to da4a81a Compare November 4, 2025 23:00
@jira-pull-request-webhook
Copy link

jira-pull-request-webhook bot commented Nov 4, 2025

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

FrankYFTang added a commit to FrankYFTang/icu that referenced this pull request Nov 5, 2025
@FrankYFTang
ICU-23252 Fix int overflow in messagepattern.cpp
5a2e763 
See unicode-org#3762
@FrankYFTang FrankYFTang force-pushed the ICU-23252FixIntOverflowInMsgFmt branch from 39decb3 to 5a2e763 Compare November 5, 2025 00:04
@jira-pull-request-webhook
Copy link

jira-pull-request-webhook bot commented Nov 5, 2025

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

FrankYFTang added a commit to FrankYFTang/icu that referenced this pull request Nov 5, 2025
@FrankYFTang
ICU-23252 Fix int overflow in messagepattern.cpp
e86da62 
See unicode-org#3762
@FrankYFTang FrankYFTang force-pushed the ICU-23252FixIntOverflowInMsgFmt branch from d148e2f to e86da62 Compare November 5, 2025 00:07
@jira-pull-request-webhook
Copy link

jira-pull-request-webhook bot commented Nov 5, 2025

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

markusicu
markusicu reviewed Nov 5, 2025
View reviewed changes
FrankYFTang added a commit to FrankYFTang/icu that referenced this pull request Nov 5, 2025
@FrankYFTang
ICU-23252 Fix int overflow in messagepattern.cpp
e6c6dae 
See unicode-org#3762
@FrankYFTang FrankYFTang force-pushed the ICU-23252FixIntOverflowInMsgFmt branch from 6da5569 to e6c6dae Compare November 5, 2025 00:37
@jira-pull-request-webhook
Copy link

jira-pull-request-webhook bot commented Nov 5, 2025

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang FrankYFTang requested a review from markusicu November 5, 2025 00:37
@FrankYFTang
Copy link
Contributor Author

FrankYFTang commented Nov 5, 2025

PTAL sorry

@markusicu
Copy link
Member

markusicu commented Nov 5, 2025

please run mvn spotless:apply on the command line; it wants to add an empty line somewhere

@markusicu
Copy link
Member

markusicu commented Nov 5, 2025

also, please don't squash until all checks pass and the PR is approved. constant squashing makes it very hard to keep track of issues, comments, and changes.

@FrankYFTang FrankYFTang force-pushed the ICU-23252FixIntOverflowInMsgFmt branch from e6c6dae to 5d863d7 Compare November 5, 2025 20:57
@jira-pull-request-webhook
Copy link

jira-pull-request-webhook bot commented Nov 5, 2025

Notice: the branch changed across the force-push!

  • icu4j/main/core/src/test/java/com/ibm/icu/dev/test/format/MessageRegressionTest.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang
Copy link
Contributor Author

FrankYFTang commented Nov 5, 2025

done! PTAL

@FrankYFTang FrankYFTang force-pushed the ICU-23252FixIntOverflowInMsgFmt branch from 5d863d7 to 852b4b5 Compare November 5, 2025 22:16
@jira-pull-request-webhook
Copy link

jira-pull-request-webhook bot commented Nov 5, 2025

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang FrankYFTang merged commit 59577f6 into unicode-org:main Nov 5, 2025
105 checks passed
@FrankYFTang FrankYFTang deleted the ICU-23252FixIntOverflowInMsgFmt branch November 5, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markusicu markusicu markusicu approved these changes

Assignees

@markusicu markusicu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FrankYFTang @markusicu