Skip to content

Commit 3d4868b

Browse files
authored
Merge pull request #71 from w3c/tripu/various-fixes
Various fixes after merging #70
2 parents 051b4bd + 7c12a24 commit 3d4868b

File tree

4 files changed

+9
-11
lines changed

4 files changed

+9
-11
lines changed

README.md

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# W3C's i18n Checker
1+
# W3C's i18n Checker
22

33
This checker performs various tests on a Web Page to determine its level of internationalisation-friendliness. It also summarises key internationalization information about a page, such as character encoding and language declarations, etc.
44

@@ -13,14 +13,12 @@ This software is free/open source, licensed under the terms of the [W3C software
1313

1414
There is a set of [installation notes](https://github.com/w3c/i18n-checker/wiki/Installation-notes) for those who want to work with the source code.
1515

16-
Proposals for changes to the checker must be submitted via pull requests, and will need to be reviewed by someone other than the proposer before merging with the master branch. The file tests/index.php should be run before submitting a pull request, to ensure that the changes don't break existing tests.
16+
Proposals for changes to the checker must be submitted via pull requests, and will need to be reviewed by someone other than the proposer before merging with the master branch. The file `www/test.php` should be run before submitting a pull request, to ensure that the changes don't break existing tests.
1717

18-
When submitting a pull requests for a new check, you should
18+
When submitting a pull requests for a new check, you should
1919

2020
1. add new tests for that check in tests/data.php
21-
2. add calls to those tests to tests/index.php, and ensure that none of the previous tests break
21+
2. add calls to those tests to `www/test.php`, and ensure that none of the previous tests break
2222
3. add the check to doc/checker.en.php
2323
4. add parsed data that may be useful elsewhere to the class.Parser.php file, but add the actual test to class.Checker.php
2424
5. add the full set of messages and links needed for the report to langs/en.properties
25-
26-

langs/en.properties

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ footer_home="Home"
4444
footer_home_title="Go to the Home Page for The W3C Internationalization Checker Service"
4545
footer_translation="Translations"
4646
footer_translation_title="Help us translate this service"
47-
footer_version="Version 2"
47+
footer_version="Version 2.0.3"
4848
footer_version_title="Follow the link for change log"
4949

5050
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
@@ -395,7 +395,7 @@ rep_lang_malformed_attr_expl[]="Attributes values must contain a maximum of one
395395
rep_lang_malformed_attr_expl[]="<p><b class="note">Note:</b> This check doesn't count subtags following the <code class='kw' translate='no'>x</code>-, <code class='kw' translate='no'>t-</code> or <code class='kw' translate='no'>u-</code> singletons.</p>"
396396
rep_lang_malformed_attr_expl[]="<p><b class="note">Note:</b> The information table at the top of this page lists all the language tags used in the page tested. This report doesn't capture all the potential issues related to those language tags. The language tags listed in the table each link to the Language Subtag Lookup tool. You should follow those links to get a fuller picture.</p>"
397397
rep_lang_malformed_attr_todo[]="Change the attribute values to conform to BCP47 syntax rules."
398-
rep_lang_malformed_attr_todo[]="You can check whether your language tag value is valid using the 'check' input of the <a href="https://r12a.github.io/apps-subtags/">Language Subtag Lookup</a> tool."
398+
rep_lang_malformed_attr_todo[]="You can check whether your language tag value is valid using the 'check' input of the <a href="https://r12a.github.io/app-subtags/">Language Subtag Lookup</a> tool."
399399
rep_lang_malformed_attr_link[]="<a target='_blank' href='http://www.w3.org/International/techniques/authoring-html#gslang'>Language declarations explained</a>"
400400
rep_lang_malformed_attr_link[]="<a target='_blank' href='http://www.w3.org/International/techniques/authoring-html#langvalues'>Choosing language values</a>"
401401

src/class.Checker.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ private function addInfoLangTags() {
255255
$value = null;
256256
if ($this->doc->langTags != null) {
257257
foreach ($this->doc->langTags as $val) {
258-
$results[] = '<a target="_blank" href="http://r12a.github.io/apps-subtags/?check='.$val.'">'.$val.'</a>';
258+
$results[] = '<a target="_blank" href="http://r12a.github.io/app-subtags/?check='.$val.'">'.$val.'</a>';
259259
}
260260
}
261261
$code = count($results) == 0 ? null : 'Click each tag to check it.';

www/versions.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@
1414
<h2>Change log for the W3C Internationalization (i18n) Checker</h2>
1515
<p>This page documents changes to the checker. The page <a href="https://www.w3.org/International/quicktips/doc/checker">Internationalization Checker reports</a> lists all checks made, with the report messages and links to tests. New and updated checks listed below link to that page for details.</p>
1616
<p>Please let us know about bugs and missing features using the <a href="https://github.com/w3c/i18n-checker/issues">feedback form</a>. Detailed change logs can be found in the <a href="https://github.com/w3c/i18n-checker/commits/master">GitHub commit list</a>.</p>
17-
<h3 id="about">Version 2</h3>
17+
<h3 id="about">Version 2.0.3</h3>
1818

1919
<div class="bd compact">
20-
<p>Version 2 of the checker moves away from checking against particular specifications to checking how a page will work in a browser. For the most part, it assumes that pages will be parsed using an HTML5 compliant parser. Pages served as application/xhtml+xml have some significant differences with regards to character encoding and language declarations, however, and these are taken into account if the checker detects that the page being checked is served as XML.</p>
20+
<p>Version 2.0.3 of the checker moves away from checking against particular specifications to checking how a page will work in a browser. For the most part, it assumes that pages will be parsed using an HTML5 compliant parser. Pages served as application/xhtml+xml have some significant differences with regards to character encoding and language declarations, however, and these are taken into account if the checker detects that the page being checked is served as XML.</p>
2121
<p>The following new checks were added. Follow the links for details.</p>
2222
<ul style="margin-left:3em;">
2323
<li><a href="https://www.w3.org/International/quicktips/doc/checker#rep_charset_bom_diff_encoding">UTF-8 BOM disagrees with another declaration</a></li>

0 commit comments

Comments
 (0)