Refer to byte/bit sequences instead of octet/bit strings #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
approved these changes
Jan 9, 2025
Member
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
I skimmed through this, but this looks correct to me. Thanks for aligning the language, that'll help future readers.
| <p> | ||
| An <dfn id="dfn-octet-string">octet string</dfn> is an ordered sequence of zero or more | ||
| integers, each in the range 0 to 255 inclusive. | ||
| The term [= byte sequence =] is defined in [[Infra]]. |
Member
There was a problem hiding this comment.
Typically you have a line like this:
This specification depends on the Infra Standard. [INFRA]
Member
Author
There was a problem hiding this comment.
Yeah, I was looking at that for #268, but there's still a few other inconsistencies with the language there, so I'll add that later 😊
Member
Author
|
Thanks for the reviews! |
github-actions bot
added a commit
that referenced
this pull request
Jan 9, 2025
SHA: efe2685 Reason: push, by twiss Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #396.
Refer to Infra's byte sequences instead of defining our own octet string concept, and rename bit strings to bit sequences to match. Also, link to Infra's byte sequence/length where appropriate, and properly define the length in bits.
Preview | Diff