👋 trying to 3.1.9 release for macos sequoia, but ran into the following build failure
clang -Wno-implicit-function-declaration -g -O2 -o ipmiutil ipmiutil.o ialarms.o ihealth.o ievents.o ifru.o ifru_picmg.o igetevent.o ireset.o icmd.o ilan.o isensor.o isel.o iserial.o iwdt.o isol.o idiscover.o iconfig.o ipicmg.o ifirewall.o ifwum.o ihpm.o itsol.o idcmi.o iuser.o oem_kontron.o oem_fujitsu.o oem_intel.o oem_sun.o oem_supermicro.o oem_dell.o oem_quanta.o oem_hp.o oem_newisys.o oem_lenovo.o oem_asus.o iekanalyzer.o ipmicmd.o mem_if.o ipmidir.o imbapi.o ipmimv.o ipmild.o ipmibmc.o ipmilipmi.o subs.o md5.o md2.o ipmilan.o ipmilanplus.o -lpthread
if [ "xno" = "xyes" ]; then \
ar x ; \
ar cru libipmiutil.a ipmicmd.o mem_if.o ipmidir.o imbapi.o ipmimv.o ipmild.o ipmibmc.o ipmilipmi.o subs.o md5.o md2.o obj/ipmilanL.o obj/ipmilanplusL.o ; \
ranlib libipmiutil.a; \
else \
ar cru libipmiutil.a ipmicmd.o mem_if.o ipmidir.o imbapi.o ipmimv.o ipmild.o ipmibmc.o ipmilipmi.o subs.o md5.o md2.o obj/ipmilanA.o obj/ipmilanplusA.o ; \
ranlib libipmiutil.a ; \
fi
ld: pointer not aligned in '_vFlash_completion_code_vals'+0x1 (/private/tmp/ipmiutil-20240916-45987-c1391g/ipmiutil-3.1.9/util/oem_dell.o)
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [ipmiutil] Error 1
Diff:
It looks like this particuar compiler does not handle these 'const struct vFlashstr' declarations properly. It must need the struct defined explicitly. There are several other oem*.c files affected if so.
const struct vFlashstr vFlash_completion_code_vals[] = {... };
I have attached an updated ocm_dell.c which should work better. Please try with that and let me know if it gets past ocm_dell.c now.
Thanks for the patch, it actually should be
rather than
Other than that, it works well for me, thanks!
gonna ship with https://github.com/Homebrew/homebrew-core/pull/191136
Another thing, I also saw some checksum change with the ipmiutil-3.1.9.tar.gz
was there some aritfact re-uploading for 3.1.9 release? Thanks!
any thoughts?
Attached is the updated oem_dell.c
Yes, there was an updated library file added in 3.1.9
Thanks Andy, I have shipped the patch via https://github.com/Homebrew/homebrew-core/pull/191136, this issue can be closed.