Static optimizers for constant folding#804
Merged
TristonianJones merged 4 commits intogoogle:masterfrom Aug 30, 2023
Merged
Conversation
TristonianJones
force-pushed
the
optimizer
branch
9 times, most recently
from
6e72efa to
ec77e3c
Compare
TristonianJones
force-pushed
the
optimizer
branch
2 times, most recently
from
bc82f3b to
a9dc6fa
Compare
TristonianJones
force-pushed
the
optimizer
branch
from
a9dc6fa to
4552f21
Compare
l46kok
reviewed
Aug 25, 2023
Collaborator
l46kok
left a comment
l46kok
left a comment
There was a problem hiding this comment.
Submitting what I have so far -- the literal adaptation and optional handling is sufficiently complex. It could be a good idea to create abstractions for them to reuse them across other optimizer implementations.
TristonianJones
changed the title
l46kok
previously approved these changes
Aug 30, 2023
Collaborator
Author
|
PTAL |
l46kok
approved these changes
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for constant folding and configurable optimizers.
Constant folding introduces several API changes to support the construction
ASTs which are intended to be type-check and unparser friendly. The constant
folding algorithm exercises many parts of this new framework and does
best effort folding through comprehension expressions as well.
Static optimizers are standalone instances and not configured as part of the standard
environment simply because their options, configurations, and sequencing may be
use-case specific and might not fit well within the parse -> compile -> eval flow.