Closed Bug 2010501 Opened 21 days ago Closed 13 days ago

DNS drop down under privacy and security is broken after 147

Categories

(Firefox :: Settings UI, defect)

Firefox 147
defect

Tracking

()

VERIFIED FIXED
149 Branch
Tracking Status
firefox-esr140 --- unaffected
firefox147 --- verified
firefox148 --- verified
firefox149 --- verified

People

(Reporter: bjbzvgi, Assigned: bvandersloot)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [necko-triaged])

Attachments

(4 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:147.0) Gecko/20100101 Firefox/147.0

Steps to reproduce:

updated from 146.2, go to settings>privacy and security

Actual results:

Blank box where it shows which dns is being used and where you could change the dns

Expected results:

Box should show current dns info and dropdown to change

The Bugbug bot thinks this bug should belong to the 'Core::Networking: DNS' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Networking: DNS
Product: Firefox → Core

Might this have something to do with geo-specific TRRs being no longer available, maybe for travel reasons?

Flags: needinfo?(valentin.gosu)
Flags: needinfo?(bjbzvgi)

I would expect the new UI we shipped in bug 1971428 to be visible, instead of the old one.
Benjamin, do you have an idea of what went wrong here?

Flags: needinfo?(valentin.gosu) → needinfo?(bvandersloot)
See Also: → 1971428

The strings for that UI are still not finalized, so we haven't released them to localization, so we can't enable past Nightly. This groupbox, if rendered, should be entirely unchanged by the work in bug 1971428

Flags: needinfo?(bvandersloot)

@Reporter, Could you open devtools console on the settings page (Ctrl-Shift-K) and let us know if there are any errors?
Thanks!

I'm on 147.0.1 now and the same thing happens.

the console shows a warning:

[fluent-dom] An element named "icon" wasn't found in the source.

Flags: needinfo?(bjbzvgi)
Severity: -- → S4
Flags: needinfo?(valentin.gosu)
Priority: -- → P2
Whiteboard: [necko-triaged]

(In reply to bjbzvgi from comment #6)

I'm on 147.0.1 now and the same thing happens.

the console shows a warning:

[fluent-dom] An element named "icon" wasn't found in the source.

Not sure if this one is what causes the issue.
If there are no more warnings there, could you also look at the browser console (Ctrl-Shift-J) and see if there are any warnings there?
Otherwise, you might be able to use https://mozilla.github.io/mozregression/install.html using your existing profile to determine what introduced the problem.

Severity: S4 → --
Component: Networking: DNS → Settings UI
Flags: needinfo?(valentin.gosu)
Priority: P2 → --
Product: Core → Firefox
Flags: needinfo?(bjbzvgi)

(In reply to Valentin Gosu [:valentin] (he/him) from comment #7)

(In reply to bjbzvgi from comment #6)

I'm on 147.0.1 now and the same thing happens.

the console shows a warning:

[fluent-dom] An element named "icon" wasn't found in the source.

Not sure if this one is what causes the issue.
If there are no more warnings there, could you also look at the browser console (Ctrl-Shift-J) and see if there are any warnings there?
Otherwise, you might be able to use https://mozilla.github.io/mozregression/install.html using your existing profile to determine what introduced the problem.

That was the only line when using ctrl+shift+k , i made sure i wasn't filtering out errors.
thanks for the mozgression suggestion, I'm hesitant to go down that route though, I’ll use the advanced settings if i need to change the dns for now.

with ctrl+shift+j:

Errors:

Error: Error(s) encountered during statement execution: datatype mismatch Sqlite.sys.mjs:1095:25
ExtensionError: No such native application mozillavpn ExtensionUtils.sys.mjs:48:5
TypeError: sectionData is undefined AboutPreferences.sys.mjs:193:18
Content process 9708 isn't responsive while sending "DevToolsProcessParent:addOrSetSessionDataEntry" request. DevTools will ignore this process for now. 3 DevToolsProcessParent.sys.mjs:320:17
Content process 9708 is responsive again. DevTools resumes operations against it. DevToolsProcessParent.sys.mjs:330:21
NotFoundError: No such JSProcessActor 'DevToolsProcess'
NotFoundError: No such JSProcessActor 'BrowserToolboxDevToolsProcess'
TypeError: sectionData is undefined AboutPreferences.sys.mjs:193:18
Uncaught (in promise) TypeError: can't access property "removeAttribute", notificationsDoNotDisturbBox is null
init chrome://browser/content/preferences/privacy.js:3580
init chrome://browser/content/preferences/preferences.js:323
initializeCategories chrome://browser/content/preferences/findInPage.js:130
init chrome://browser/content/preferences/findInPage.js:78
privacy.js:3580:7

Warnings:

Window.fullScreen attribute is deprecated and will be removed in the future. browser-customtitlebar.js:68:7
In add-on {446900e4-71c2-419f-a6a7-df9c091e268b}, attempting to use listener "notifications.onButtonClicked", which is unimplemented. ExtensionParent.sys.mjs:1330:13
Key event not available on some keyboard layouts: key=“z” modifiers=“control,alt” id=“toggleSidebarKb” browser.xhtml
Key event not available on some keyboard layouts: key=“x” modifiers=“accel,alt” id=“viewGenaiChatSidebarKb” browser.xhtml
Key event not available on some keyboard layouts: key=“w” modifiers=“accel,alt” id=“” browser.xhtml
Key event not available on some keyboard layouts: key=“s” modifiers=“accel,alt” id=“ext-key-id-tab-stash_condordes_net-sidebar-action” browser.xhtml
Key event not available on some keyboard layouts: key=“t” modifiers=“accel,alt” id=“” browser.xhtml
Key event not available on some keyboard layouts: key=“x” modifiers=“accel,alt” id=“” browser.xhtml
Key event not available on some keyboard layouts: key=“q” modifiers=“accel,alt” id=“” browser.xhtml
Key event not available on some keyboard layouts: key=“s” modifiers=“accel,alt” id=“” browser.xhtml
Key event not available on some keyboard layouts: key=“t” modifiers=“accel,alt” id=“” browser.xhtml
Key event not available on GTK2: key=“u” modifiers=“accel,shift” id=“” browser.xhtml
Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox” browser.xhtml
WindowsJumpLists: Failed to fetch favicon for https://trakt.tv/dashboard NS_ERROR_FAILURE: WindowsJumpLists.sys.mjs:257:29
[fluent-dom] An element named "icon" wasn't found in the source. 2 preferences
WindowsJumpLists: Failed to fetch favicon for https://trakt.tv/dashboard NS_ERROR_FAILURE: WindowsJumpLists.sys.mjs:257:29

Flags: needinfo?(bjbzvgi)

Thank you for posting the warnings. I think there are two potential issues here:

AboutPreferences.renderPreferenceSection

gPrivacyPane.init for notificationsDoNotDisturbBox.
It makes sense that if this gPrivacyPane.init() throws an exception, initDoH isn't called, so the UI isn't populated.
It seems notificationsDoNotDisturbBox was touched in bug 1972371.
Ben, could you have a look?

Flags: needinfo?(bvandersloot)
See Also: → 1972371

Yep. Looks like some code that is only hit when the do not disturb service is manual was referencing an old object in the tree. I'll clean that out and submit a patch.

Flags: needinfo?(bvandersloot)
Assignee: nobody → bvandersloot
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Status: ASSIGNED → RESOLVED
Closed: 13 days ago
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch

Bug 1972371 removed the vbox with id="notificationsDoNotDisturbBox"

Keywords: regression
Regressed by: 1972371
See Also: 1972371

Set release status flags based on info from the regressing bug 1972371

The patch landed in nightly and beta is affected.
:bvandersloot, is this bug important enough to require an uplift?

For more information, please visit BugBot documentation.

Flags: needinfo?(bvandersloot)
Attachment #9540051 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined: Privacy page settings at the bottom of the page will not work for users with manual do not disturb settings available.
  • Code covered by automated testing: yes
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: Removing code that causes UI issues.
  • String changes made/needed: no
  • Is Android affected?: no

firefox-release Uplift Approval Request

  • User impact if declined: Privacy page settings at the bottom of the page will not work for users with manual do not disturb settings available.
  • Code covered by automated testing: yes
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: Removing code that causes UI issues.
  • String changes made/needed: no
  • Is Android affected?: no
Attachment #9540053 - Flags: approval-mozilla-release?
Attachment #9540051 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Duplicate of this bug: 2011096

Uplifts filed!

Flags: needinfo?(bvandersloot)
Duplicate of this bug: 2012671
Attachment #9540053 - Flags: approval-mozilla-release? → approval-mozilla-release+
QA Whiteboard: [qa-ver-needed-c149/b148]
Flags: qe-verify+
QA Contact: cgeorgiu

I'm able to reproduce this bug using an affected Firefox 147.0.1 with Win 10 x64.

The issue is verified as fixed on the latest builds, Nightly 149.0a1, Beta 148.0b10 and Firefox 147.0.3. Tested with Win 10 x64.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-ver-needed-c149/b148] → [qa-ver-done-c149/b148]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: