Enhancement proposal for Cloudformation templates#769
Open
Pelirrojo wants to merge 3 commits intoJetBrains:masterfrom
Open
Enhancement proposal for Cloudformation templates#769Pelirrojo wants to merge 3 commits intoJetBrains:masterfrom
Pelirrojo wants to merge 3 commits intoJetBrains:masterfrom
Conversation
Adding a more complex running sample with comments, parameters, outputs and opinionated best practices about UI
Adding a more complex running sample with comments, parameters, outputs and opinionated best practices about UI
Updating changes
Author
|
Hello, With this pull request I would like to offer an improvement in the cloudformation base templates, currently they only create one EC2 resource and I suggest that they have the four most common sections and an example of comments. The same example is in the two accepted formats: json and yaml. Do you find it interesting to merge it? Is there any contributing document that you have not seen or followed? Thanks in advance, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Below are two small additions to the cloudformation base templates. These include:
The main improvement is that these templates are tested and work and help to generate modular templates that accept parameters and have easily reusable outputs